You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/25 12:36:00 UTC
[GitHub] [ignite] Vladsz83 opened a new pull request #9525: IGNITE-15183 : Add thin clients thread pool monitoring
Vladsz83 opened a new pull request #9525:
URL: https://github.com/apache/ignite/pull/9525
Changes: thin client pool has been moved into PoolProcessor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] Vladsz83 commented on a change in pull request #9525: IGNITE-15183 : Add thin clients thread pool monitoring
Posted by GitBox <gi...@apache.org>.
Vladsz83 commented on a change in pull request #9525:
URL: https://github.com/apache/ignite/pull/9525#discussion_r744703615
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/pool/PoolProcessor.java
##########
@@ -498,6 +503,18 @@ public PoolProcessor(GridKernalContext ctx) {
rebalanceExecSvc.allowCoreThreadTimeOut(true);
+ if (cfg.getClientConnectorConfiguration() != null) {
+ thinClientExec = new IgniteThreadPoolExecutor(
+ "client-connector",
+ cfg.getIgniteInstanceName(),
+ cfg.getClientConnectorConfiguration().getThreadPoolSize(),
+ cfg.getClientConnectorConfiguration().getThreadPoolSize(),
+ 0,
+ new LinkedBlockingQueue<>(),
+ GridIoPolicy.UNDEFINED,
+ new OomExceptionHandler(ctx));
Review comment:
Fixed
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/ClientListenerProcessor.java
##########
@@ -366,12 +354,6 @@ private void unregisterMBean() {
ctx.ports().deregisterPorts(getClass());
- if (execSvc != null) {
- U.shutdownNow(getClass(), execSvc, log);
-
- execSvc = null;
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9525: IGNITE-15183 : Add thin clients thread pool monitoring
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #9525:
URL: https://github.com/apache/ignite/pull/9525#discussion_r744694434
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/ClientListenerProcessor.java
##########
@@ -366,12 +354,6 @@ private void unregisterMBean() {
ctx.ports().deregisterPorts(getClass());
- if (execSvc != null) {
- U.shutdownNow(getClass(), execSvc, log);
-
- execSvc = null;
Review comment:
Let's keep only this line
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/pool/PoolProcessor.java
##########
@@ -498,6 +503,18 @@ public PoolProcessor(GridKernalContext ctx) {
rebalanceExecSvc.allowCoreThreadTimeOut(true);
+ if (cfg.getClientConnectorConfiguration() != null) {
+ thinClientExec = new IgniteThreadPoolExecutor(
+ "client-connector",
+ cfg.getIgniteInstanceName(),
+ cfg.getClientConnectorConfiguration().getThreadPoolSize(),
+ cfg.getClientConnectorConfiguration().getThreadPoolSize(),
+ 0,
+ new LinkedBlockingQueue<>(),
+ GridIoPolicy.UNDEFINED,
+ new OomExceptionHandler(ctx));
Review comment:
`new OomExceptionHandler(ctx)` -> `oomeHnd`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #9525: IGNITE-15183 : Add thin clients thread pool monitoring
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #9525:
URL: https://github.com/apache/ignite/pull/9525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org