You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "hboutemy (via GitHub)" <gi...@apache.org> on 2023/09/18 06:36:32 UTC
[GitHub] [maven-artifact-plugin] hboutemy opened a new pull request, #19: [MARTIFACT-47] add compare.fail property
hboutemy opened a new pull request, #19:
URL: https://github.com/apache/maven-artifact-plugin/pull/19
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] slawekjaranowski commented on a diff in pull request #19: [MARTIFACT-47] add compare.fail property
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #19:
URL: https://github.com/apache/maven-artifact-plugin/pull/19#discussion_r1328422094
##########
src/main/java/org/apache/maven/plugins/artifact/buildinfo/CompareMojo.java:
##########
@@ -95,6 +95,12 @@ public class CompareMojo extends AbstractBuildinfoMojo {
@Parameter(defaultValue = "${project.remoteProjectRepositories}", readonly = true)
private List<RemoteRepository> remoteRepos;
+ /**
+ * Fail the build if differences are found against reference build.
+ */
Review Comment:
please add `@since`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy merged pull request #19: [MARTIFACT-47] add compare.fail property
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy merged PR #19:
URL: https://github.com/apache/maven-artifact-plugin/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org