[GitHub] [spark] LuciferYang commented on a change in pull request #35580: [SPARK-38257][BUILD] Upgrade `rockdbjni` to 6.29.4.1

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #35580:
URL: https://github.com/apache/spark/pull/35580#discussion_r835884770



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
##########
@@ -177,7 +177,7 @@ class RocksDB(
         numKeysOnWritingVersion -= 1
       }
     }
-    writeBatch.remove(key)
+    writeBatch.delete(key)

Review comment:
         The `remove` series method of `WriteBatch` is identified as `@Deprecated` in 6.x and [deleted in 7.x](https://github.com/facebook/rocksdb/pull/9576), here use `delete` instead 
   
   Am I right @adamretter ？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org