[GitHub] jihaozh closed pull request #3646: [TE] fix database connection close issue

[GitBox <gi...@apache.org>]

jihaozh closed pull request #3646: [TE] fix database connection close issue
URL: https://github.com/apache/incubator-pinot/pull/3646
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/datalayer/bao/jdbc/TaskManagerImpl.java b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/datalayer/bao/jdbc/TaskManagerImpl.java
index 4f887d4ff0..e7941f864e 100644
--- a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/datalayer/bao/jdbc/TaskManagerImpl.java
+++ b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/datalayer/bao/jdbc/TaskManagerImpl.java
@@ -172,12 +172,11 @@ public int deleteRecordsOlderThanDaysWithStatus(int days, TaskStatus status) {
 
   @Override
   public int countWaiting() {
-    try {
-      // NOTE: this aggregation should be supported by genericPojoDAO directly
-      Connection connection = this.genericPojoDao.getConnection();
-      PreparedStatement statement = connection.prepareStatement(COUNT_WAITING_TASKS);
-      return statement.executeQuery().getInt(0);
-
+    // NOTE: this aggregation should be supported by genericPojoDAO directly
+    try (Connection connection = this.genericPojoDao.getConnection();
+        PreparedStatement statement = connection.prepareStatement(COUNT_WAITING_TASKS);
+        ResultSet rs = statement.executeQuery()){
+      return rs.getInt(0);
     } catch (Exception e) {
       LOG.warn("Could not retrieve task backlog size. Defaulting to -1.", e);
       return -1;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org