You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/17 17:02:01 UTC
[GitHub] [druid] gianm opened a new pull request #11940: Use intermediate-persist IndexSpec during multiphase merge.
gianm opened a new pull request #11940:
URL: https://github.com/apache/druid/pull/11940
The main change is the addition of an intermediate-persist IndexSpec
to the main "merge" method in IndexMerger. There are also a few minor
adjustments to the IndexMerger interface to encourage more harmonious
usage of its methods in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11940: Use intermediate-persist IndexSpec during multiphase merge.
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11940:
URL: https://github.com/apache/druid/pull/11940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11940: Use intermediate-persist IndexSpec during multiphase merge.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11940:
URL: https://github.com/apache/druid/pull/11940#issuecomment-974308098
> I'm not sure why that would be; maybe it's a caching thing on the Travis side? Restarting the test doesn't help. Is there a "super-restart"?
I deleted all the Travis caches, maybe that'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11940: Use intermediate-persist IndexSpec during multiphase merge.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11940:
URL: https://github.com/apache/druid/pull/11940#issuecomment-976004971
> I deleted all the Travis caches, maybe that'll do it.
Looks like that helped!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11940: Use intermediate-persist IndexSpec during multiphase merge.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11940:
URL: https://github.com/apache/druid/pull/11940#issuecomment-973002342
This patch is getting nailed for test coverage in UnifiedIndexerAppenderatorsManager's LimitedPoolIndexMerger. In looking into this I've noticed that the class does need more tests, but also that a lot of IndexMerger interface methods are currently unused. Rather than add tests for all these unused methods, I'm looking into removing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11940: Use intermediate-persist IndexSpec during multiphase merge.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11940:
URL: https://github.com/apache/druid/pull/11940#issuecomment-973029973
I pushed a change that removes the unused-in-production IndexMerger methods "append" and "convert", and adds additional unit tests to UnifiedIndexerAppenderatorsManager. Hopefully this will satisfy the coverage checker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #11940: Use intermediate-persist IndexSpec during multiphase merge.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11940:
URL: https://github.com/apache/druid/pull/11940#issuecomment-974185910
The "analyze hadoop 3 dependencies" step keeps failing with this error:
```
[ERROR] error reading /home/travis/.m2/repository/com/amazonaws/aws-java-sdk-bundle/1.11.901/aws-java-sdk-bundle-1.11.901.jar; error in opening zip file
[ERROR] error reading /home/travis/.m2/repository/com/amazonaws/aws-java-sdk-bundle/1.11.901/aws-java-sdk-bundle-1.11.901.jar; cannot read zip file
```
I'm not sure why that would be; maybe it's a caching thing on the Travis side? Restarting the test doesn't help. Is there a "super-restart"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org