You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/31 22:49:13 UTC
[GitHub] [cordova-plugin-media-capture] ath0mas opened a new pull request #214: (iOS) Capture video with 'quality' param
ath0mas opened a new pull request #214:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/214
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Use `quality` param for video capture on iOS too.
Here is my suggested implementation based on previous PR #162 by @larrybahr with changes after my review and more tests.
### Description
<!-- Describe your changes in detail -->
Follow iOS logic about video quality: [doc](https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619154-videoquality?language=objc)
`quality` value of `0` for [UIImagePickerControllerQualityTypeLow](https://developer.apple.com/documentation/uikit/uiimagepickercontrollerqualitytype/uiimagepickercontrollerqualitytypelow?language=objc), `0.5` for [UIImagePickerControllerQualityTypeMedium](https://developer.apple.com/documentation/uikit/uiimagepickercontrollerqualitytype/uiimagepickercontrollerqualitytypemedium?language=objc), or `1` for [UIImagePickerControllerQualityTypeHigh](https://developer.apple.com/documentation/uikit/uiimagepickercontrollerqualitytype/uiimagepickercontrollerqualitytypehigh?language=objc).
For any other value or when `quality` param is not provided we use _UIImagePickerControllerQualityTypeMedium_, as it is iOS default.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Confirmed the _switch-case_ resolution with various `quality` values: 0, 0.5, 1, 2, 'foo', false, undefined, and without any captureOpts.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] gbrits commented on pull request #214: (iOS) Capture video with 'quality' param
Posted by GitBox <gi...@apache.org>.
gbrits commented on pull request #214:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/214#issuecomment-839363999
🚀 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-media-capture] ath0mas commented on pull request #214: (iOS) Capture video with 'quality' param
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #214:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/214#issuecomment-843571622
@gbrits waiting for this merge and some others, so I currently use my own published fork [cordova-plugin-ns0m-media-capture](https://github.com/ns0m/cordova-plugin-ns0m-media-capture)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org