You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2025/01/27 11:04:26 UTC
[PR] Proofread CVE fix versions [logging-site]
ppkarwasz opened a new pull request, #6:
URL: https://github.com/apache/logging-site/pull/6
This PR double checks which Log4j Core versions resolved which vulnerabilities.
## Branch `2.3.x`
**https://github.com/advisories/GHSA-fxph-q3j8-mv87** (server class) was never fixed, the TCP/UDP socket server is still there.
**https://github.com/advisories/GHSA-vwqq-5vrc-xw9h** (host name validation) was fixed in `2.3.2`:
- https://github.com/apache/logging-log4j2/commit/3c62f0bea692456b1b5039d3bcc1c3e0ba65146a
**https://github.com/advisories/GHSA-jfh8-c2jp-5v3q** (Log4Shell) was fixed in `2.3.1`:
- https://github.com/apache/logging-log4j2/commit/be848dacbac6df30c4f32b2852e24446033ecf79
- https://github.com/apache/logging-log4j2/commit/f6564bb993d547d0a371b75d869042c334bf57f0
**https://github.com/advisories/GHSA-7rjr-3q55-vv33** (Log4Shell through recursive lookup evaluation) was fixed in `2.3.1`:
- https://github.com/apache/logging-log4j2/commit/f6564bb993d547d0a371b75d869042c334bf57f0
**https://github.com/advisories/GHSA-p6xc-xr62-6r2g** (DoS through recursive lookup evaluation) was fixed in `2.3.1`:
- https://github.com/apache/logging-log4j2/commit/ce6b78d082aae89089cb3ad25cdd46e9ec70a70b
**https://github.com/advisories/GHSA-8489-44mv-ggj8** (RCE if you have access to configuration) was fixed in `2.3.1`:
- https://github.com/apache/logging-log4j2/commit/f6564bb993d547d0a371b75d869042c334bf57f0
## Branch `2.12.x`
**https://github.com/advisories/GHSA-vwqq-5vrc-xw9h** (host name validation) was fixed in `2.12.3`:
- https://github.com/apache/logging-log4j2/commit/2bcba12b185200b7f3f2532cbfeff1e1da0d5c81
- https://github.com/apache/logging-log4j2/commit/bb94ea9fa921a61f90b6a934600567e719419ddd
**https://github.com/advisories/GHSA-jfh8-c2jp-5v3q** (Log4Shell) was fixed in `2.12.2`:
- https://github.com/apache/logging-log4j2/commit/70edc233343815d5efa043b54294a6fb065aa1c5
- https://github.com/apache/logging-log4j2/commit/f819c83804152cb6ed94cb408302e36b21b65053
**https://github.com/advisories/GHSA-7rjr-3q55-vv33** (Log4Shell through recursive lookup evaluation) was fixed in `2.12.3`:
- https://github.com/apache/logging-log4j2/commit/bf8ba18f63ab9f9ffd54387c5c527ecc7a681037
**https://github.com/advisories/GHSA-p6xc-xr62-6r2g** (DoS through recursive lookup evaluation) was fixed in `2.12.3`:
- https://github.com/apache/logging-log4j2/commit/bf7e916df6335713fe2219c7b3b523fb509deabc
**https://github.com/advisories/GHSA-8489-44mv-ggj8** (RCE if you have access to configuration) was fixed in `2.12.3`:
- https://github.com/apache/logging-log4j2/commit/bf8ba18f63ab9f9ffd54387c5c527ecc7a681037
**Note**: Unless I am mistaken, version `2.12.4` didn't contain any security updates.
## Main `2.x` branch
**https://github.com/advisories/GHSA-jfh8-c2jp-5v3q** (Log4Shell) was fixed in `2.15.0`:
- https://github.com/apache/logging-log4j2/commit/c77b3cb39312b83b053d23a2158b99ac7de44dd3
- https://github.com/apache/logging-log4j2/commit/001aaada7dab82c3c09cde5f8e14245dc9d8b454
**https://github.com/advisories/GHSA-7rjr-3q55-vv33** (Log4Shell through recursive lookup evaluation) was fixed in `2.16.0`:
- https://github.com/apache/logging-log4j2/commit/c362aff473e9812798ff8f25f30a2619996605d5
- https://github.com/apache/logging-log4j2/commit/27972043b76c9645476f561c5adc483dec6d3f5d
**https://github.com/advisories/GHSA-p6xc-xr62-6r2g** (DoS through recursive lookup evaluation) was fixed in `2.12.3`:
- https://github.com/apache/logging-log4j2/commit/806023265f8c905b2dd1d81fd2458f64b2ea0b5e
**https://github.com/advisories/GHSA-8489-44mv-ggj8** (RCE if you have access to configuration) was fixed in `2.12.3`:
- https://github.com/apache/logging-log4j2/commit/95b24f77e77e4f1e5cc794df5332643e944fd6f8
**Note**: Unless I am mistaken, version `2.17.1` didn't contain any security updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1932009167
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
The way I see it:
- CVE-2021-44228 is about JNDI lookup injection through the `%m` pattern. It was fixed in `2.15.0`.
- JNDI lookups could come from the recursive evaluation of `${ctx:…}` and that is why we issued CVE-2021-45046 and disabled the instantiation of the JNDI lookup in `2.16.0`.
- Of course other lookups are also a problem, so we issued CVE-2021-45105 and disabled recursive evaluation of lookups in `2.17.0`.
These numbers agree with those reported to the NVD and IMHO correcting the order of evaluation of `%m` patterns and disabling `${jndi:…}` lookups cuts off all ways to use the JNDI lookup. Version `2.16.0`prevents the instantiation of the lookup in `Interpolator` (its only caller):
```java
final Class<? extends StrLookup> clazz = entry.getValue().getPluginClass().asSubclass(StrLookup.class);
if (!clazz.getName().equals(JndiLookup.class.getName()) || JndiManager.isJndiEnabled()) {
strLookupMap.put(entry.getKey().toLowerCase(), ReflectionUtil.instantiate(clazz));
}
```
(see [source code](https://github.com/apache/logging-log4j2/blob/cffe58f6a433ea1ab60ceb129d4c9b3377acda1d/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java#L80-L83))
https://github.com/apache/logging-log4j2/commit/4a4b7530b1848e630a65d79e9c7dc388a5a7785b only seems to double down this protection and throws exceptions from the constructor of the JNDI Lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1996372079
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
@raboof: we can add some `see also` in the descriptions, to point users to other problems they could encounter with `2.15.0` and `2.16.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1931873759
##########
_vulnerabilities.adoc:
##########
@@ -32,8 +32,8 @@ We only extend this mathematical notation with set union operator (i.e., `∪`)
|Summary |JDBC appender is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |6.6 MEDIUM (CVSS:3.1/AV:N/AC:H/PR:H/UI:N/S:U/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta7, 2.3.2) ∪ [2.4, 2.12.4) ∪ [2.13.0, 2.17.1)`
-|Versions fixed |`2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later)
+|Versions affected |`[2.0-beta7, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
+|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later)
Review Comment:
1. Shouldn't this stay `2.3.2`, since it adds `isJndiJdbcEnabled()` to the `isJndiEnabled` in apache/logging-log4j2@ae4dc0c1a6389ae895f60451cd87e97e7b9d85c1?
2. Same for `2.12.4` due to apache/logging-log4j2@b3879958cb3b75eb16bf27e970538b6e4e130f1c
3. Same for `2.17.1` due to apache/logging-log4j2@05db5f9527254632b59aed2a1d78a32c5ab74f16
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
There are several JNDI-related hardening in `2.17.0`, e.g., apache/logging-log4j2@4a4b7530b1848e630a65d79e9c7dc388a5a7785b. Since this is the min. (Java 8 compatible) version we claim to be _not_ vulnerable by Log4shell, do you imply `2.17.0..2.17.1` changes contain no Log4shell-related fixes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1932009167
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
The way I see it:
- CVE-2021-44228 is about JNDI lookup injection through the `%m` pattern. It was fixed in `2.15.0`.
- JNDI lookups could come from the recursive evaluation of `${ctx:…}` and that is why we issued CVE-2021-45046 (and CVE-2021-45105), which were fixed in `2.16.0`.
These numbers agree with those reported to the NVD and IMHO correcting the order of evaluation of `%m` patterns and removing recursive evaluation of `${…}` lookups cuts off all sources of user data that could be fed to the JNDI lookup.
In case we forgot some call paths that lead to the JNDI lookup, version `2.16.0`also prevents the instantiation of the lookup in `Interpolator` (its only caller):
```java
final Class<? extends StrLookup> clazz = entry.getValue().getPluginClass().asSubclass(StrLookup.class);
if (!clazz.getName().equals(JndiLookup.class.getName()) || JndiManager.isJndiEnabled()) {
strLookupMap.put(entry.getKey().toLowerCase(), ReflectionUtil.instantiate(clazz));
}
```
(see [source code](https://github.com/apache/logging-log4j2/blob/cffe58f6a433ea1ab60ceb129d4c9b3377acda1d/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java#L80-L83))
Version `2.17.0` (https://github.com/apache/logging-log4j2/commit/4a4b7530b1848e630a65d79e9c7dc388a5a7785b) only seems to double down this (possibly unnecessary protection) and throws exceptions from the constructor of the JNDI Lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r3764334328
##########
_vulnerabilities.adoc:
##########
@@ -32,8 +32,8 @@ We only extend this mathematical notation with set union operator (i.e., `∪`)
|Summary |JDBC appender is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |6.6 MEDIUM (CVSS:3.1/AV:N/AC:H/PR:H/UI:N/S:U/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta7, 2.3.2) ∪ [2.4, 2.12.4) ∪ [2.13.0, 2.17.1)`
-|Versions fixed |`2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later)
+|Versions affected |`[2.0-beta7, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
+|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later)
Review Comment:
These releases do not contain the JDBC-specific fix. In the `rel/2.3.1`, `rel/2.12.3`, and `rel/2.17.0` tags, `DataSourceConnectionSource` still passes the configured name directly to `InitialContext.lookup`; routing it through the restricted `JndiManager` first appears in 2.3.2, 2.12.4, and 2.17.1. Restore those affected ranges and fixed versions.
##########
_vulnerabilities.adoc:
##########
@@ -45,13 +45,14 @@ This issue is fixed by limiting JNDI data source names to the `java` protocol.
[#CVE-2021-44832-mitigation]
==== Mitigation
-Upgrade to `2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later).
+Upgrade to `2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later).
Review Comment:
This mitigation recommends releases that still perform the vulnerable JDBC data-source lookup without protocol filtering. Users need 2.3.2, 2.12.4, or 2.17.1 for CVE-2021-44832; recommending the earlier versions leaves them exposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r2007041906
##########
_vulnerabilities.adoc:
##########
@@ -32,8 +32,8 @@ We only extend this mathematical notation with set union operator (i.e., `∪`)
|Summary |JDBC appender is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |6.6 MEDIUM (CVSS:3.1/AV:N/AC:H/PR:H/UI:N/S:U/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta7, 2.3.2) ∪ [2.4, 2.12.4) ∪ [2.13.0, 2.17.1)`
-|Versions fixed |`2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later)
+|Versions affected |`[2.0-beta7, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
+|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later)
Review Comment:
@ppkarwasz, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1995006760
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
I prefer being cautious, keeping the affected version range at `..., 2.17.0)`, and not saying _"`2.16.0` should be fine against JNDI issues reported in CVE-2021-44228"_ unless we are certain about – of which I am not.
@raboof, @rgoers, @jvz, we need a tiebreaker. Would you mind sharing your thoughts, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #6:
URL: https://github.com/apache/logging-site/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "rgoers (via GitHub)" <gi...@apache.org>.
rgoers commented on PR #6:
URL: https://github.com/apache/logging-site/pull/6#issuecomment-2723881567
First, I think you should link to https://musigma.blog/2023/11/10/log4shell-history.html. While Matt's page says Log4Shell was fixed in 2.16.0 my recollection was that 2.17.0 was the only release I would recommend. I believe that was the release where Carter finally resolved the problems with recursive lookups.
FWIW - 44228 was NOT just about JNDI. It was the combination of the JNDI bug with the recursive lookup on message data that caused Log4Shell. While both were bad, either on their own would not have been anywhere near as serious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1995312754
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
I was not around when log4shell happened so take my input with a grain of salt, but my understanding so far is:
From a purely practical perspective, without looking at the technical side at all, the details of the the version metadata we have published to Mitre for CVE-2021-45046 (https://www.cve.org/CVERecord?id=CVE-2021-45046) is that only versions before 1.16.0 were affected.
While I agree with erring on the safe side, as we cannot widen affected version ranges on already-published CVEs, the low-friction way to make things consistent might be to have CVE-2021-45046 listed as affecting versions before 1.16.0, but add references highlighting that operators should also consider the follow-ups CVE-2021-45105 and CVE-2021-44832 and make sure to upgrade to 1.17.1 (1.17.0?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "jvz (via GitHub)" <gi...@apache.org>.
jvz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1996228917
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
The JNDI lookup issues were all fixed in 2.16.0. The JNDI-related bugs fixed in 2.17+ were only relevant in a scenario where either the adversary has control over the logging configuration (which is outside the threat model we published later on for clarification) or in a scenario where a JNDI URL is used to configure a plugin that uses JNDI for something (such as the JDBC and JMS appenders) and the JNDI URL either points to a compromised LDAP server or the URL is somehow user-configurable (the latter also being outside the scope of our threat model).
While 2.16.0 fixes the JNDI-related issues from log4shell, it didn't fix all _possible_ JNDI-related issues. It was in 2.17.0 where we introduced a feature flag to enable JNDI at all to avoid potential use of these JNDI-linked classes in some sort of gadget chain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r2007074657
##########
_vulnerabilities.adoc:
##########
@@ -32,8 +32,8 @@ We only extend this mathematical notation with set union operator (i.e., `∪`)
|Summary |JDBC appender is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |6.6 MEDIUM (CVSS:3.1/AV:N/AC:H/PR:H/UI:N/S:U/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta7, 2.3.2) ∪ [2.4, 2.12.4) ∪ [2.13.0, 2.17.1)`
-|Versions fixed |`2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later)
+|Versions affected |`[2.0-beta7, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
+|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later)
Review Comment:
[LOG4J2-3242 "Limit JNDI to the java protocol only"](https://issues.apache.org/jira/browse/LOG4J2-3242) was implemented one patch version before.
Regardless whether the behavior in [CVE-2021-44832](https://www.cve.org/CVERecord?id=CVE-2021-44832) is a vulnerability or not, in versions `2.3.1`, `2.12.3` and `2.17.0` it was not possible to use JNDI schemas other than `java:`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r2007133349
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
Let me be absurdly provocative here: should we add `log4j:log4j` (all versions) to the list of artifacts affected by CVE-2021-44228?
I agree with Ralph: version `2.17.0` is the **first** version I would recommend. The reason is not CVE-2021-45046, but CVE-2021-45105.
Anyway the main reason for this PR is to align our version numbers with those submitted to the CVE database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1932009167
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
The way I see it:
- CVE-2021-44228 is about JNDI lookup injection through the `%m` pattern. It was fixed in `2.15.0`.
- JNDI lookups could come from the recursive evaluation of `${ctx:…}` and that is why we issued CVE-2021-45046 (and CVE-2021-45105), which were fixed in `2.16.0`.
These numbers agree with those reported to the NVD and IMHO correcting the order of evaluation of `%m` patterns and removing recursive evaluation of `${…}` lookups cuts off all sources of user data that could be fed to the JNDI lookup.
In case we forgot some call paths that lead to the JNDI lookup, version `2.16.0`also prevents the instantiation of the lookup in `Interpolator` (its only caller):
```java
final Class<? extends StrLookup> clazz = entry.getValue().getPluginClass().asSubclass(StrLookup.class);
if (!clazz.getName().equals(JndiLookup.class.getName()) || JndiManager.isJndiEnabled()) {
strLookupMap.put(entry.getKey().toLowerCase(), ReflectionUtil.instantiate(clazz));
}
```
(see [source code](https://github.com/apache/logging-log4j2/blob/cffe58f6a433ea1ab60ceb129d4c9b3377acda1d/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java#L80-L83))
Version `2.17.0` (https://github.com/apache/logging-log4j2/commit/4a4b7530b1848e630a65d79e9c7dc388a5a7785b) only seems to double down this (possibly unnecessary) protection and throws exceptions from the constructor of the JNDI Lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r2007044573
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
In conclusion,
- @ppkarwasz, @jvz, and @raboof are +1
- @rgoers and I are -1
Let's stick to the information reflected in the CVEs and move on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #6:
URL: https://github.com/apache/logging-site/pull/6#issuecomment-2724317413
> First, I think you should link to https://musigma.blog/2023/11/10/log4shell-history.html. While Matt's page says Log4Shell was fixed in 2.16.0 my recollection was that 2.17.0 was the only release I would recommend. I believe that was the release where Carter finally resolved the problems with recursive lookups.
The main change in this PR is the statement that `2.17.0` did **not** contain the [CVE-2021-44832](https://nvd.nist.gov/vuln/detail/CVE-2021-44832) vulnerability (i.e. remote code execution by modification of the configuration of a JDBC appender). The NVD entry states "This issue is fixed by limiting JNDI data source names to the java protocol in Log4j2 versions 2.17.1, 2.12.4, and 2.3.2.", but this is incorrect, since the limitation was introduced in `2.17.0`:
https://github.com/apache/logging-log4j2/commit/f6564bb993d547d0a371b75d869042c334bf57f0
**Note**:
I wouldn't recommend `2.17.0` either, since:
- It is **not** the latest patch release of the `2.17.x` branch. Version `2.17.2` IMHO should have been a `MINOR` release, but let us keep it simple: you should **always** upgrade to the last patch release of the minor release you use, without questioning. If suddenly maintainers decide to release patches to an old minor version (as it happened `2.3.x` or `2.12.x`) there must be a reason.
- It is **not** maintained any more. Sure, users that only use documented properties and features, should be able to upgrade to `2.24.3` **without** any problems, but somehow problems always appear on such big upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1931891281
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
There are several JNDI-related hardening in `2.17.0`, e.g., 4a4b7530b1848e630a65d79e9c7dc388a5a7785b. Since this is the min. (Java 8 compatible) version we claim to be _not_ vulnerable by Log4shell, do you imply `2.17.0..2.17.1` changes contain no Log4shell-related fixes?
##########
_vulnerabilities.adoc:
##########
@@ -32,8 +32,8 @@ We only extend this mathematical notation with set union operator (i.e., `∪`)
|Summary |JDBC appender is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |6.6 MEDIUM (CVSS:3.1/AV:N/AC:H/PR:H/UI:N/S:U/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta7, 2.3.2) ∪ [2.4, 2.12.4) ∪ [2.13.0, 2.17.1)`
-|Versions fixed |`2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later)
+|Versions affected |`[2.0-beta7, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
+|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later)
Review Comment:
1. Shouldn't this stay `2.3.2`, since it adds `isJndiJdbcEnabled()` to the `isJndiEnabled` in ae4dc0c1a6389ae895f60451cd87e97e7b9d85c1?
2. Same for `2.12.4` due to b3879958cb3b75eb16bf27e970538b6e4e130f1c
3. Same for `2.17.1` due to 05db5f9527254632b59aed2a1d78a32c5ab74f16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r1932009167
##########
_vulnerabilities.adoc:
##########
@@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein
|Summary |Thread Context Lookup is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |9.0 CRITICAL (CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
-|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), and `2.17.0` (for Java 8 and later)
+|Versions affected |`[2.0-beta9, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.16.0)`
Review Comment:
The way I see it:
- CVE-2021-44228 is about JNDI lookup injection through the `%m` pattern. It was fixed in `2.15.0`.
- JNDI lookups could come from the recursive evaluation of `${ctx:…}` and that is why we issued CVE-2021-45046 (and CVE-2021-45105), which were fixed in `2.16.0`.
These numbers agree with those reported to the NVD and IMHO correcting the order of evaluation of `%m` patterns and removing recursive evaluation of `${…}` lookups cuts off all sources of user data that could be fed to the JNDI lookup.
In case we forgot some call paths that lead to the JNDI lookup, version `2.16.0`also prevents the instantiation of the lookup in `Interpolator` (its only caller):
https://github.com/apache/logging-log4j2/blob/cffe58f6a433ea1ab60ceb129d4c9b3377acda1d/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java#L80-L82
Version `2.17.0` (https://github.com/apache/logging-log4j2/commit/4a4b7530b1848e630a65d79e9c7dc388a5a7785b) only seems to double down this (possibly unnecessary protection) and throws exceptions from the constructor of the JNDI Lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Proofread CVE fix versions [logging-site]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #6:
URL: https://github.com/apache/logging-site/pull/6#discussion_r3764415957
##########
_vulnerabilities.adoc:
##########
@@ -32,8 +32,8 @@ We only extend this mathematical notation with set union operator (i.e., `∪`)
|Summary |JDBC appender is vulnerable to remote code execution in certain configurations
|CVSS 3.x Score & Vector |6.6 MEDIUM (CVSS:3.1/AV:N/AC:H/PR:H/UI:N/S:U/C:H/I:H/A:H)
|Components affected |`log4j-core`
-|Versions affected |`[2.0-beta7, 2.3.2) ∪ [2.4, 2.12.4) ∪ [2.13.0, 2.17.1)`
-|Versions fixed |`2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later)
+|Versions affected |`[2.0-beta7, 2.3.1) ∪ [2.4, 2.12.3) ∪ [2.13.0, 2.17.0)`
+|Versions fixed |`2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later)
Review Comment:
This is hard to argue since CVE-2021-44832 does not violate any property in our threat model, but if we define allowing the operator to delegate configuration of a JDBC appender to a potentially malicious LDAP server, then I guess you are right and we should restore the higher versions.
##########
_vulnerabilities.adoc:
##########
@@ -45,13 +45,14 @@ This issue is fixed by limiting JNDI data source names to the `java` protocol.
[#CVE-2021-44832-mitigation]
==== Mitigation
-Upgrade to `2.3.2` (for Java 6), `2.12.4` (for Java 7), or `2.17.1` (for Java 8 and later).
+Upgrade to `2.3.1` (for Java 6), `2.12.3` (for Java 7), or `2.17.0` (for Java 8 and later).
Review Comment:
As above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org