You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/19 10:47:17 UTC

[GitHub] [spark] nob13 commented on a change in pull request #31244: [SPARK-34115][CORE] Check SPARK_TESTING as lazy val to avoid slowdown

nob13 commented on a change in pull request #31244:
URL: https://github.com/apache/spark/pull/31244#discussion_r560083952



##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -1939,7 +1939,15 @@ private[spark] object Utils extends Logging {
    * Indicates whether Spark is currently running unit tests.
    */
   def isTesting: Boolean = {

Review comment:
       There are a testcases which set the property IS_TESTING (e.g. SparkFunSuite), I do not wanted to break them.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org