[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4233: board/ctrl: Add BOARDIOC_BOOT_IMAGE for booting a new application image

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #4233:
URL: https://github.com/apache/incubator-nuttx/pull/4233#discussion_r678807796



##########
File path: boards/boardctl.c
##########
@@ -452,6 +452,31 @@ int boardctl(unsigned int cmd, uintptr_t arg)
         break;
 #endif
 
+#ifdef CONFIG_BOARDCTL_BOOT_IMAGE
+      /* CMD:           BOARDIOC_BOOT_IMAGE
+       * DESCRIPTION:   Boot a new application image.
+       *                Execute the required actions for booting a new
+       *                application image (e.g. deinitialize peripherals,

Review comment:
       change all application to system?

##########
File path: include/sys/boardctl.h
##########
@@ -392,6 +393,17 @@ struct boardioc_nxterm_ioctl_s
 };
 #endif /* CONFIG_NXTERM */
 
+#ifdef CONFIG_BOARDCTL_BOOT_IMAGE
+
+/* Structure containing the arguments to the BOARDIOC_BOOT_IMAGE command */
+
+struct boardioc_boot_info_s
+{
+  FAR const char *img_path;           /* Path to application image */
+  uint32_t        img_header_size;    /* Size of the image header in bytes */

Review comment:
       The header is defined by mcuboot or vendor?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org