You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/13 19:53:26 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#8958: [docs] Fix CORS section in installation
graceguo-supercat opened a new pull request #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [x] Documentation
### SUMMARY
Fix the extra CORS Dependency installation step.
### TEST PLAN
https://superset.incubator.apache.org/installation.html#cors
### ADDITIONAL INFORMATION
### REVIEWERS
@michellethomas @mistercrunch @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #8958:
[docs] Fix CORS section in installation
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958#issuecomment-574342019
CORS is optional for Superset app. it's contributed by community:
https://github.com/apache/incubator-superset/pull/478
I guess most of users/companies don't need to handle cross-domain issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8958: [docs] Fix
CORS section in installation
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958#issuecomment-574344125
What is the purpose of this change? If the purpose is to describe the process when not installing Superset via `pip`, then I think it might be better to explain when this alternative approach is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in
pull request #8958: [docs] Fix CORS section in installation
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958#discussion_r367021356
##########
File path: docs/installation.rst
##########
@@ -772,8 +772,9 @@ CORS
The extra CORS Dependency must be installed:
- superset[cors]
+.. code-block:: text
+ pip install -U flask-cors
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8958: [docs]
Fix CORS section in installation
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull
request #8958: [docs] Fix CORS section in installation
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958#discussion_r366699900
##########
File path: docs/installation.rst
##########
@@ -772,8 +772,9 @@ CORS
The extra CORS Dependency must be installed:
- superset[cors]
+.. code-block:: text
+ pip install -U flask-cors
Review comment:
It's slightly better to recommend `pip install apache-superset[cors]`, that way it will reference the version range or pinned version specified in `setup.py`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on issue #8958:
[docs] Fix CORS section in installation
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on issue #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958#issuecomment-574382281
I feel confused by the current instruction. I am ok with all options .
**Before:**
<img width="697" alt="Screen Shot 2020-01-14 at 1 19 50 PM" src="https://user-images.githubusercontent.com/27990562/72383664-c554fc00-36d0-11ea-919d-1ed7144e6817.png">
**After:**
<img width="706" alt="Screen Shot 2020-01-14 at 1 26 18 PM" src="https://user-images.githubusercontent.com/27990562/72384000-778cc380-36d1-11ea-9175-efeccda0966f.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8958: [docs]
Fix CORS section in installation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958#issuecomment-573849957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=h1) Report
> Merging [#8958](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1f6f4ed879a3bb34a50a48b55fc42c570ece8b51?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8958 +/- ##
=======================================
Coverage 58.97% 58.97%
=======================================
Files 359 359
Lines 11333 11333
Branches 2787 2787
=======================================
Hits 6684 6684
Misses 4471 4471
Partials 178 178
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=footer). Last update [1f6f4ed...c2661ff](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8958:
[docs] Fix CORS section in installation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #8958: [docs] Fix CORS section in installation
URL: https://github.com/apache/incubator-superset/pull/8958#issuecomment-573849957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=h1) Report
> Merging [#8958](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1f6f4ed879a3bb34a50a48b55fc42c570ece8b51?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8958 +/- ##
=========================================
- Coverage 58.97% 58.68% -0.3%
=========================================
Files 359 362 +3
Lines 11333 11415 +82
Branches 2787 2801 +14
=========================================
+ Hits 6684 6699 +15
- Misses 4471 4538 +67
Partials 178 178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t/assets/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkTGF5b3V0Lmpz) | `93% <0%> (-1.9%)` | :arrow_down: |
| [...et/assets/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9kYXNoYm9hcmRMYXlvdXQuanM=) | `95.09% <0%> (-1.88%)` | :arrow_down: |
| [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `41.46% <0%> (-1.78%)` | :arrow_down: |
| [...ssets/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRIZWFkZXIuanN4) | `100% <0%> (ø)` | :arrow_up: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `69.56% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/dashboard/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvaW5kZXguanM=) | `100% <0%> (ø)` | :arrow_up: |
| [...set/assets/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkSW5mby5qcw==) | `66.66% <0%> (ø)` | |
| [...rset/assets/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvYWN0aW9ucy9kYXNoYm9hcmRJbmZvLmpz) | `33.33% <0%> (ø)` | |
| [...ssets/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwuanN4) | `7.4% <0%> (ø)` | |
| [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/8958/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRGaWx0ZXJDb25maWdzRnJvbUZvcm1kYXRhLmpz) | `88.46% <0%> (+1.5%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=footer). Last update [1f6f4ed...4e9b34d](https://codecov.io/gh/apache/incubator-superset/pull/8958?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org