[GitHub] [skywalking] wankai123 commented on a diff in pull request #11194: Add `view_as_seq` function in MQE for listing metrics in the given prioritized sequence

["wankai123 (via GitHub)" <gi...@apache.org>]

wankai123 commented on code in PR #11194:
URL: https://github.com/apache/skywalking/pull/11194#discussion_r1287813013


##########
oap-server/mqe-grammar/src/main/antlr4/org/apache/skywalking/mqe/rt/grammar/MQEParser.g4:
##########
@@ -33,6 +33,11 @@ expression
     | topN L_PAREN metric COMMA parameter COMMA order R_PAREN  #topNOP
     | relabels L_PAREN expression COMMA label R_PAREN #relablesOP
     | aggregateLabels L_PAREN expression COMMA aggregateLabelsFunc R_PAREN #aggregateLabelsOp
+    | viewAsSeq L_PAREN expressionList R_PAREN #viewAsSeqOp

Review Comment:
   make sense, if there are similar expressions, but the logical processing is different, it is should to distinguish by different group names.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org