You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yukang-Lian (via GitHub)" <gi...@apache.org> on 2024/06/18 18:03:44 UTC

[PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Yukang-Lian opened a new pull request, #36499:
URL: https://github.com/apache/doris/pull/36499

   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2176685494

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2177371148

   run p1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2176763668

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.45 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 690c8ab892c8b8a9c78544040e5afaeda15b6ccb, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.08	0.04	0.04
   query3	0.22	0.04	0.05
   query4	1.68	0.08	0.07
   query5	0.51	0.48	0.48
   query6	1.12	0.73	0.73
   query7	0.02	0.02	0.01
   query8	0.04	0.04	0.05
   query9	0.56	0.49	0.48
   query10	0.54	0.56	0.54
   query11	0.14	0.11	0.11
   query12	0.14	0.11	0.12
   query13	0.58	0.58	0.59
   query14	0.79	0.77	0.81
   query15	0.82	0.80	0.82
   query16	0.37	0.37	0.36
   query17	1.00	0.96	0.98
   query18	0.23	0.22	0.24
   query19	1.89	1.82	1.69
   query20	0.01	0.01	0.01
   query21	15.42	0.65	0.66
   query22	4.01	6.95	2.11
   query23	18.32	1.28	1.24
   query24	2.20	0.21	0.21
   query25	0.16	0.10	0.10
   query26	0.26	0.18	0.17
   query27	0.08	0.08	0.09
   query28	13.25	1.01	0.99
   query29	12.67	3.28	3.19
   query30	0.26	0.06	0.06
   query31	2.90	0.38	0.39
   query32	3.25	0.47	0.48
   query33	2.86	2.95	2.89
   query34	17.02	4.37	4.37
   query35	4.52	4.50	4.44
   query36	0.66	0.47	0.45
   query37	0.17	0.15	0.15
   query38	0.15	0.15	0.14
   query39	0.04	0.03	0.03
   query40	0.18	0.14	0.14
   query41	0.09	0.05	0.04
   query42	0.05	0.05	0.04
   query43	0.04	0.04	0.04
   Total cold run time: 109.34 s
   Total hot run time: 30.45 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2176738244

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 39852 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 690c8ab892c8b8a9c78544040e5afaeda15b6ccb, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17616	4364	4300	4300
   q2	2024	186	193	186
   q3	10463	1138	1125	1125
   q4	10180	781	823	781
   q5	7481	2694	2656	2656
   q6	222	136	133	133
   q7	955	622	591	591
   q8	9232	2078	2094	2078
   q9	8900	6491	6490	6490
   q10	9010	3701	3724	3701
   q11	447	238	235	235
   q12	486	233	229	229
   q13	17773	3006	2981	2981
   q14	274	217	217	217
   q15	511	481	471	471
   q16	523	373	376	373
   q17	980	689	695	689
   q18	7938	7418	7432	7418
   q19	2516	1449	1513	1449
   q20	650	311	338	311
   q21	5004	3100	3830	3100
   q22	379	345	338	338
   Total cold run time: 113564 ms
   Total hot run time: 39852 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4412	4291	4248	4248
   q2	371	255	261	255
   q3	2963	2725	2874	2725
   q4	1982	1709	1699	1699
   q5	5533	5553	5463	5463
   q6	210	127	126	126
   q7	2239	1805	1900	1805
   q8	3296	3433	3451	3433
   q9	8701	8629	8794	8629
   q10	4125	3893	3811	3811
   q11	567	490	505	490
   q12	796	603	642	603
   q13	15853	3208	3210	3208
   q14	292	280	278	278
   q15	547	483	473	473
   q16	495	421	419	419
   q17	1836	1519	1490	1490
   q18	8181	7974	7829	7829
   q19	1785	1625	1498	1498
   q20	2138	1856	1883	1856
   q21	10605	4813	4968	4813
   q22	626	526	541	526
   Total cold run time: 77553 ms
   Total hot run time: 55677 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2176724341

   TeamCity be ut coverage result:
    Function Coverage: 36.47% (9004/24686) 
    Line Coverage: 28.02% (73766/263240)
    Region Coverage: 27.50% (38321/139350)
    Branch Coverage: 24.20% (19533/80712)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/690c8ab892c8b8a9c78544040e5afaeda15b6ccb_690c8ab892c8b8a9c78544040e5afaeda15b6ccb/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2176676530

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2176676662

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Enhancement](group commit) Use async group commit rpc call [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36499:
URL: https://github.com/apache/doris/pull/36499#issuecomment-2176754574

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173127 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 690c8ab892c8b8a9c78544040e5afaeda15b6ccb, data reload: false
   
   query1	913	381	377	377
   query2	6452	2351	2388	2351
   query3	6632	205	206	205
   query4	21439	17336	17310	17310
   query5	3617	467	471	467
   query6	238	157	157	157
   query7	4596	303	300	300
   query8	330	284	287	284
   query9	8651	2386	2375	2375
   query10	553	324	280	280
   query11	10351	10106	10006	10006
   query12	119	85	81	81
   query13	1636	364	356	356
   query14	10019	7687	6966	6966
   query15	239	209	205	205
   query16	7719	271	264	264
   query17	1911	529	517	517
   query18	1986	317	272	272
   query19	191	167	146	146
   query20	93	91	83	83
   query21	208	126	124	124
   query22	4388	4165	4155	4155
   query23	33901	33618	33365	33365
   query24	10667	2943	2910	2910
   query25	638	370	379	370
   query26	710	154	152	152
   query27	2305	333	330	330
   query28	6036	2114	2094	2094
   query29	869	624	633	624
   query30	268	154	154	154
   query31	987	766	756	756
   query32	95	55	58	55
   query33	671	324	275	275
   query34	903	485	474	474
   query35	757	638	620	620
   query36	1150	984	992	984
   query37	143	71	69	69
   query38	2983	2838	2843	2838
   query39	907	829	852	829
   query40	208	128	131	128
   query41	55	55	56	55
   query42	126	103	98	98
   query43	569	566	530	530
   query44	1107	721	724	721
   query45	198	160	163	160
   query46	1075	740	701	701
   query47	1889	1758	1768	1758
   query48	384	297	292	292
   query49	830	396	413	396
   query50	759	384	385	384
   query51	6814	6641	6694	6641
   query52	99	96	93	93
   query53	365	285	291	285
   query54	875	439	453	439
   query55	76	72	70	70
   query56	277	250	258	250
   query57	1131	1022	1068	1022
   query58	259	241	237	237
   query59	3339	3074	3001	3001
   query60	292	261	286	261
   query61	94	89	113	89
   query62	595	465	442	442
   query63	315	299	290	290
   query64	8556	2239	1753	1753
   query65	3182	3114	3092	3092
   query66	743	328	323	323
   query67	15451	15042	14932	14932
   query68	4521	534	540	534
   query69	488	363	332	332
   query70	1198	1155	1147	1147
   query71	377	276	316	276
   query72	6943	5253	5521	5253
   query73	730	330	335	330
   query74	5876	5481	5489	5481
   query75	3424	2604	2695	2604
   query76	2210	919	890	890
   query77	419	297	306	297
   query78	10176	9892	9821	9821
   query79	2135	517	519	517
   query80	1011	450	453	450
   query81	547	218	222	218
   query82	888	102	97	97
   query83	221	164	161	161
   query84	231	84	83	83
   query85	1765	307	279	279
   query86	478	336	306	306
   query87	3265	3071	3056	3056
   query88	4300	2368	2344	2344
   query89	485	402	389	389
   query90	1706	185	191	185
   query91	128	99	102	99
   query92	61	48	48	48
   query93	2495	501	507	501
   query94	1054	199	193	193
   query95	418	328	322	322
   query96	598	270	263	263
   query97	3213	3028	3008	3008
   query98	220	201	202	201
   query99	1353	819	837	819
   Total cold run time: 268868 ms
   Total hot run time: 173127 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org