You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/01 19:52:04 UTC

[GitHub] [superset] robdiciuccio opened a new pull request #16554: refactor: Update async query init to support runtime feature flags

robdiciuccio opened a new pull request #16554:
URL: https://github.com/apache/superset/pull/16554


   ### SUMMARY
   Refactors and updates the initialization of `GLOBAL_ASYNC_QUERIES` to support dynamic feature flags set at runtime.
   
   Net impact is the addition of the no-op `after_request` hook when the flag is disabled.
   
   ### TESTING INSTRUCTIONS
   Superset should function normally with the `GLOBAL_ASYNC_QUERIES` feature flag enabled and disabled.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org