You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by da...@apache.org on 2022/05/09 08:35:57 UTC
[hudi] branch master updated: [HUDI-4053] Flaky ITTestHoodieDataSource.testStreamWriteBatchReadOpti… (#5526)
This is an automated email from the ASF dual-hosted git repository.
danny0405 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 6b47ef6ed2 [HUDI-4053] Flaky ITTestHoodieDataSource.testStreamWriteBatchReadOpti… (#5526)
6b47ef6ed2 is described below
commit 6b47ef6ed223e10a05b91acc3331cff2fa069d87
Author: xicm <36...@users.noreply.github.com>
AuthorDate: Mon May 9 16:35:50 2022 +0800
[HUDI-4053] Flaky ITTestHoodieDataSource.testStreamWriteBatchReadOpti… (#5526)
* [HUDI-4053] Flaky ITTestHoodieDataSource.testStreamWriteBatchReadOptimized
Co-authored-by: xicm <xi...@asiainfo.com>
---
.../java/org/apache/hudi/table/ITTestHoodieDataSource.java | 10 +++++++++-
.../src/test/java/org/apache/hudi/utils/TestData.java | 12 ++++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java b/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java
index 088ddb260d..0c423df6b7 100644
--- a/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java
+++ b/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java
@@ -240,7 +240,15 @@ public class ITTestHoodieDataSource extends AbstractTestBase {
List<Row> rows = CollectionUtil.iterableToList(
() -> streamTableEnv.sqlQuery("select * from t1").execute().collect());
- assertRowsEquals(rows, TestData.DATA_SET_SOURCE_INSERT);
+
+ // the test is flaky based on whether the first compaction is pending when
+ // scheduling the 2nd compaction.
+ // see details in CompactionPlanOperator#scheduleCompaction.
+ if (rows.size() < TestData.DATA_SET_SOURCE_INSERT.size()) {
+ assertRowsEquals(rows, TestData.DATA_SET_SOURCE_INSERT_FIRST_COMMIT);
+ } else {
+ assertRowsEquals(rows, TestData.DATA_SET_SOURCE_INSERT);
+ }
}
@Test
diff --git a/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestData.java b/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestData.java
index c1e924056c..61f1657c2c 100644
--- a/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestData.java
+++ b/hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestData.java
@@ -164,6 +164,18 @@ public class TestData {
TimestampData.fromEpochMillis(8000), StringData.fromString("par4"))
);
+ // data set of test_source.data first commit.
+ public static List<RowData> DATA_SET_SOURCE_INSERT_FIRST_COMMIT = Arrays.asList(
+ insertRow(StringData.fromString("id1"), StringData.fromString("Danny"), 23,
+ TimestampData.fromEpochMillis(1000), StringData.fromString("par1")),
+ insertRow(StringData.fromString("id2"), StringData.fromString("Stephen"), 33,
+ TimestampData.fromEpochMillis(2000), StringData.fromString("par1")),
+ insertRow(StringData.fromString("id3"), StringData.fromString("Julian"), 53,
+ TimestampData.fromEpochMillis(3000), StringData.fromString("par2")),
+ insertRow(StringData.fromString("id4"), StringData.fromString("Fabian"), 31,
+ TimestampData.fromEpochMillis(4000), StringData.fromString("par2"))
+ );
+
// data set of test_source.data latest commit.
public static List<RowData> DATA_SET_SOURCE_INSERT_LATEST_COMMIT = Arrays.asList(
insertRow(StringData.fromString("id5"), StringData.fromString("Sophia"), 18,