You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tomasz Pik (JIRA)" <ji...@codehaus.org> on 2006/08/11 12:02:20 UTC
[jira] Created: (MWAR-67) webResource filtering needs filter
webResource filtering needs filter
----------------------------------
Key: MWAR-67
URL: http://jira.codehaus.org/browse/MWAR-67
Project: Maven 2.x War Plugin
Issue Type: Bug
Reporter: Tomasz Pik
Priority: Minor
Filtering of webResources works only, if there's at least one <filter>path/to/properties</filter> defined in pom.
So without such a configuration there's no possiblity to build war file with filtering using values specified during build invocation, with -D options (System properties are ignored).
Adding reference to (even empty) file using <filter> element 'solves' the problem and properties defined using -D are used.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-67) webResource filtering needs filter
Posted by "Robert Watkins (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-67?page=comments#action_84835 ]
Robert Watkins commented on MWAR-67:
------------------------------------
While this patch allows for properties to be specified on the command line, it doesn't allow properties to be specified in a profile.
Setting properties for filtering in a profile works with normal JAR resources.
> webResource filtering needs filter
> ----------------------------------
>
> Key: MWAR-67
> URL: http://jira.codehaus.org/browse/MWAR-67
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Reporter: Tomasz Pik
> Assigned To: Brett Porter
> Priority: Minor
> Fix For: 2.0.2
>
> Attachments: MWAR-67-maven-war-plugin-2.patch, MWAR-67-maven-war-plugin.patch
>
>
> Filtering of webResources works only, if there's at least one <filter>path/to/properties</filter> defined in pom.
> So without such a configuration there's no possiblity to build war file with filtering using values specified during build invocation, with -D options (System properties are ignored).
> Adding reference to (even empty) file using <filter> element 'solves' the problem and properties defined using -D are used.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-67) webResource filtering needs filter
Posted by "Franz Allan Valencia See (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-67?page=all ]
Franz Allan Valencia See updated MWAR-67:
-----------------------------------------
Attachment: MWAR-67-maven-war-plugin.patch
Tomasz Pik, you can use MWAR-67-maven-war-plugin.patch in the mean time.
This patch will allow you to use -D option without specifying a filter property file. However, this still lacks the neccessary test cases for that. i'm just going to submit another patch once i've finished the tests.
> webResource filtering needs filter
> ----------------------------------
>
> Key: MWAR-67
> URL: http://jira.codehaus.org/browse/MWAR-67
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Reporter: Tomasz Pik
> Priority: Minor
> Attachments: MWAR-67-maven-war-plugin.patch
>
>
> Filtering of webResources works only, if there's at least one <filter>path/to/properties</filter> defined in pom.
> So without such a configuration there's no possiblity to build war file with filtering using values specified during build invocation, with -D options (System properties are ignored).
> Adding reference to (even empty) file using <filter> element 'solves' the problem and properties defined using -D are used.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MWAR-67) webResource filtering needs filter
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-67?page=all ]
Brett Porter closed MWAR-67.
----------------------------
Assignee: Brett Porter
Resolution: Fixed
Fix Version/s: 2.0.2
> webResource filtering needs filter
> ----------------------------------
>
> Key: MWAR-67
> URL: http://jira.codehaus.org/browse/MWAR-67
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Reporter: Tomasz Pik
> Assigned To: Brett Porter
> Priority: Minor
> Fix For: 2.0.2
>
> Attachments: MWAR-67-maven-war-plugin-2.patch, MWAR-67-maven-war-plugin.patch
>
>
> Filtering of webResources works only, if there's at least one <filter>path/to/properties</filter> defined in pom.
> So without such a configuration there's no possiblity to build war file with filtering using values specified during build invocation, with -D options (System properties are ignored).
> Adding reference to (even empty) file using <filter> element 'solves' the problem and properties defined using -D are used.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-67) webResource filtering needs filter
Posted by "Franz Allan Valencia See (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MWAR-67?page=all ]
Franz Allan Valencia See updated MWAR-67:
-----------------------------------------
Attachment: MWAR-67-maven-war-plugin-2.patch
MWAR-67-maven-war-plugin-2.patch contains what MWAR-67-maven-war-plugin.patch has plus a modified testExplodedWar_WithResourceFiltering() of the WarExplodedMojoTest Class.
> webResource filtering needs filter
> ----------------------------------
>
> Key: MWAR-67
> URL: http://jira.codehaus.org/browse/MWAR-67
> Project: Maven 2.x War Plugin
> Issue Type: Bug
> Reporter: Tomasz Pik
> Priority: Minor
> Attachments: MWAR-67-maven-war-plugin-2.patch, MWAR-67-maven-war-plugin.patch
>
>
> Filtering of webResources works only, if there's at least one <filter>path/to/properties</filter> defined in pom.
> So without such a configuration there's no possiblity to build war file with filtering using values specified during build invocation, with -D options (System properties are ignored).
> Adding reference to (even empty) file using <filter> element 'solves' the problem and properties defined using -D are used.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira