You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/31 09:34:34 UTC

[GitHub] [airflow] ashb edited a comment on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10

ashb edited a comment on issue #5677: [AIRFLOW-5063] Fix performance when switching between master/v1-10
URL: https://github.com/apache/airflow/pull/5677#issuecomment-516774578
 
 
   This commit has changed the behaviour of `mypy airflow/some/file.py` -- it's ignoring the settings we have in `setup.cfg` because mypy.ini now exists and is empty.
   
   ```
   $ mypy airflow/operators/docker_operator.py
   mypy.ini: No [mypy] section in config file
   airflow/www/widgets.py:20: error: Cannot find module named 'flask_appbuilder.widgets'
   ```
   
   I don't get how this helps with switching branches even ignoring this bug above? **Edit** okay looked at the rest of the PR and that makes sense. I think we just shouldn't have this empty mypy.ini file, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services