You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/07 07:21:57 UTC

[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on issue #1904: Remove ScheduleUtil，use the existing CronUtils

Jave-Chen commented on issue #1904: Remove ScheduleUtil，use the existing CronUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1904#issuecomment-583266469
 
 
   ```
   CronExpression cronExpression = null;
   try {
       cronExpression = CronUtils.parse2CronExpression(item.getCrontab());
       List<Date> list = CronUtils.getSelfFireDateList(start, end, cronExpression);
       listDate.addAll(list);
   } catch (ParseException e) {
       logger.error(e.getMessage(), e);
       continue;
   }
   ```
   
   These code are duplicated, is it possible to encapsulate then as a method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services