You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/02/01 15:10:53 UTC

[GitHub] [arrow] westonpace commented on pull request #33940: GH-15098: [C++] fix util::EqualityComparable to compile on clang c++20

westonpace commented on PR #33940:
URL: https://github.com/apache/arrow/pull/33940#issuecomment-1412221359

   I've rebased so the tests will run again and I'll see how close we are.  If I can get this to pass without much more effort it still seems like it will be a good thing.  For example, I think allowing `Scalar == std::shared_ptr<Scalar>` is a bit permissive and unusual and that sort of thing tends to lead to surprises and bugs.  Clang-15 support would be a nice bonus.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org