You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/03/11 18:25:43 UTC
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review76081
-----------------------------------------------------------
src/slave/flags.hpp
<https://reviews.apache.org/r/29328/#comment123483>
Could you add this flag also the the docs/configuration.md?
src/slave/flags.hpp
<https://reviews.apache.org/r/29328/#comment123484>
..containers*.*
- Joerg Schad
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29328: Add option to disable docker containerizer
killing orphans
Posted by Timothy Chen <tn...@apache.org>.
> On March 11, 2015, 5:25 p.m., Joerg Schad wrote:
> > src/slave/flags.hpp, line 325
> > <https://reviews.apache.org/r/29328/diff/4/?file=824288#file824288line325>
> >
> > Could you add this flag also the the docs/configuration.md?
This is fixed in a later commit.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29328/#review76081
-----------------------------------------------------------
On Jan. 17, 2015, 1:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29328/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 1:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add option to disable docker containerizer killing orphans
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/slave/flags.hpp a4498e6
>
> Diff: https://reviews.apache.org/r/29328/diff/
>
>
> Testing
> -------
>
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>