You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "mneethiraj (via GitHub)" <gi...@apache.org> on 2025/03/24 02:07:51 UTC
[PR] RANGER-5174: fix for script engine instantiation failure [ranger]
mneethiraj opened a new pull request, #546:
URL: https://github.com/apache/ranger/pull/546
## What changes were proposed in this pull request?
Updated script engine creator implementations to use the classloader that loaded the creator instance, while creating script engine instances, instead of current thread's classloader.
## How was this patch tested?
Verified that Trino plugin successfully evaluates expressions in row-filter policies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5174: fix for script engine instantiation failure [ranger]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj merged PR #546:
URL: https://github.com/apache/ranger/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5174: fix for script engine instantiation failure [ranger]
Posted by "mneethiraj (via GitHub)" <gi...@apache.org>.
mneethiraj commented on PR #546:
URL: https://github.com/apache/ranger/pull/546#issuecomment-2746947906
> The code changes look good to me. I noticed that all three script engine creators (Graal, JavaScript, and Nashorn) implement the ScriptEngineCreator interface.
>
> I was wondering if there's a specific reason for not implementing the 'getDefaultClassloader' method for all three ScriptEngineCreator implementations, instead relying on the default implementation for all three?
I added the `default` method in the interface to avoid code duplication in all 3 implementations. Do you see any issues with using this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RANGER-5174: fix for script engine instantiation failure [ranger]
Posted by "vyommani (via GitHub)" <gi...@apache.org>.
vyommani commented on PR #546:
URL: https://github.com/apache/ranger/pull/546#issuecomment-2746971278
> I added the `default` method in the interface to avoid code duplication in all 3 implementations. Do you see any issues with using this approach?
No, I completely agree with you - avoiding code duplication is a top priority, and your solution effectively achieves that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org