[PR] THRIFT-6330: Add a GitHub Actions CI job for the JavaScript library [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G opened a new pull request, #3922:
URL: https://github.com/apache/thrift/pull/3922

   `lib/js` has no job in `build.yml`, so its browser test suite does not run in CI. THRIFT-6319 made `make -C lib/js check` do real work again and added a `lib-ts` job, but that job only covers the TypeScript pages.
   
   The new `lib-js` job follows `lib-ts`, with two differences:
   
   - **It builds Java first.** `lib/js/test/build.xml` stops unless `lib/java/build/libs` holds two jars, the library and its test classes. Gradle builds the test classes only as `testJar`, which `make -C lib/java` does not run, so the job runs `make -C lib/java` and then `gradle testJar`. That avoids the Java test suite (`make -C lib/java check`, 90 s in `lib-java-kotlin`). Java 17 and Gradle 8.4 are set up as in `lib-java-kotlin`.
   - **It checks grunt's output, not ant's.** `make -C lib/js check` runs `ant test` and then grunt. The ant half skips its own browser test when phantomjs is missing and still reports `BUILD SUCCESSFUL`, so the job greps the QUnit totals that grunt prints. Like `lib-ts`, it also asserts that configure enabled Java and found npm.
   
   Verified in a container (thrift:jammy: Ubuntu 22.04, Java 17, Gradle 8.4, Node 20) by running the job's own `run:` blocks, taken from the YAML:
   
   | | result |
   |---|---|
   | the job's steps on this branch | all pass; 9 QUnit targets, 161 tests, 726 assertions, 0 failed |
   | ant half only, grunt skipped | make exits 0, and the QUnit grep fails the step |
   | configure without Java | the configure assertion fails the step |
   
   `build.yml` parses as YAML, and zizmor reports no findings.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] THRIFT-6330: Add a GitHub Actions CI job for the JavaScript library [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G merged PR #3922:
URL: https://github.com/apache/thrift/pull/3922


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org