You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Guodong Wang <wa...@gmail.com> on 2013/04/22 04:48:50 UTC
Review Request: fix NullPointerException in MesosScheduler when using
fairscheduler as the underlying scheduler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10695/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
As the title
Diffs
-----
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 133776104ec8a070fc9ce7bb8657b3c0936ee7e6
Diff: https://reviews.apache.org/r/10695/diff/
Testing
-------
Manual test is done.
Thanks,
Guodong Wang
Re: Review Request: fix NullPointerException in MesosScheduler when using
fairscheduler as the underlying scheduler
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10695/#review19588
-----------------------------------------------------------
Thanks Guodong! Can you mark this review as submitted?
I submitted this for you, feel free to subscribe to mesos-commits@incubator.apache.org if you want to be notified of commits!
- Ben Mahler
On April 23, 2013, 3:13 a.m., Guodong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10695/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 3:13 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> As the title
>
>
> This addresses bug MESOS-438.
> https://issues.apache.org/jira/browse/MESOS-438
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 133776104ec8a070fc9ce7bb8657b3c0936ee7e6
>
> Diff: https://reviews.apache.org/r/10695/diff/
>
>
> Testing
> -------
>
> Manual test is done.
>
>
> Thanks,
>
> Guodong Wang
>
>
Re: Review Request: fix NullPointerException in MesosScheduler when using
fairscheduler as the underlying scheduler
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10695/#review19587
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 23, 2013, 3:13 a.m., Guodong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10695/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 3:13 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> As the title
>
>
> This addresses bug MESOS-438.
> https://issues.apache.org/jira/browse/MESOS-438
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 133776104ec8a070fc9ce7bb8657b3c0936ee7e6
>
> Diff: https://reviews.apache.org/r/10695/diff/
>
>
> Testing
> -------
>
> Manual test is done.
>
>
> Thanks,
>
> Guodong Wang
>
>
Re: Review Request: fix NullPointerException in MesosScheduler when using
fairscheduler as the underlying scheduler
Posted by Guodong Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10695/
-----------------------------------------------------------
(Updated April 23, 2013, 3:13 a.m.)
Review request for mesos, Vinod Kone and Ben Mahler.
Changes
-------
add comments, and put the JIRA issue ID in bugs
Description
-------
As the title
This addresses bug MESOS-438.
https://issues.apache.org/jira/browse/MESOS-438
Diffs (updated)
-----
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 133776104ec8a070fc9ce7bb8657b3c0936ee7e6
Diff: https://reviews.apache.org/r/10695/diff/
Testing
-------
Manual test is done.
Thanks,
Guodong Wang
Re: Review Request: fix NullPointerException in MesosScheduler when using
fairscheduler as the underlying scheduler
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10695/#review19530
-----------------------------------------------------------
Ship it!
Thanks Guodong! Can you set the 'Bugs' on this page to the one you created in JIRA? MESOS-438
hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java
<https://reviews.apache.org/r/10695/#comment40316>
Can you add a comment above this line:
// The Hadoop Fair Scheduler is known to return null.
- Ben Mahler
On April 22, 2013, 2:48 a.m., Guodong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10695/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 2:48 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> As the title
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 133776104ec8a070fc9ce7bb8657b3c0936ee7e6
>
> Diff: https://reviews.apache.org/r/10695/diff/
>
>
> Testing
> -------
>
> Manual test is done.
>
>
> Thanks,
>
> Guodong Wang
>
>
Re: Review Request: fix NullPointerException in MesosScheduler when using
fairscheduler as the underlying scheduler
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10695/#review19531
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 22, 2013, 2:48 a.m., Guodong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10695/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 2:48 a.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> As the title
>
>
> Diffs
> -----
>
> hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java 133776104ec8a070fc9ce7bb8657b3c0936ee7e6
>
> Diff: https://reviews.apache.org/r/10695/diff/
>
>
> Testing
> -------
>
> Manual test is done.
>
>
> Thanks,
>
> Guodong Wang
>
>