You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Chris Schmidt (JIRA)" <ji...@apache.org> on 2008/02/06 02:07:08 UTC
[jira] Created: (JCR-1362) DatabaseJournal improperly finds tables
in external schemas when used on Oracle
DatabaseJournal improperly finds tables in external schemas when used on Oracle
-------------------------------------------------------------------------------
Key: JCR-1362
URL: https://issues.apache.org/jira/browse/JCR-1362
Project: Jackrabbit
Issue Type: Bug
Affects Versions: 1.4, 1.3.3
Reporter: Chris Schmidt
The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
ResultSet rs = metaData.getTables(null, null, tableName, null);
The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1362) DatabaseJournal improperly finds
tables in external schemas when used on Oracle
Posted by "Chris Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565982#action_12565982 ]
Chris Schmidt commented on JCR-1362:
------------------------------------
More of a refactoring request, but could the code that handles DB interaction be extracted to a common utility class (or set of classes)? The current implementation violates the DRY principle and could cause additional maintenance issues in the future.
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit
> Issue Type: Bug
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1362) DatabaseJournal improperly finds tables
in external schemas when used on Oracle
Posted by "Martijn Hendriks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Hendriks updated JCR-1362:
----------------------------------
Attachment: JCR-1362.patch
The Oracle tablespace and SqlServer filegroup support have already been added (see JCR-968 and JCR-1295). The attached patch solves this issue.
I agree with Chris that we should very probably think about refactoring all or most of the DB interaction into a set of utility classes. The fact that this Oracle issue has popped up three times for different parts of the code (this issue, JCR-814 and JCR-582) underlines the lurking maintenance problems.
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core, sql
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
> Assignee: Martijn Hendriks
> Attachments: JCR-1362.patch
>
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1362) DatabaseJournal improperly finds tables
in external schemas when used on Oracle
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1362:
-------------------------------
Fix Version/s: core 1.4.6
Merged to the 1.4 branch in revision 695887.
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core, sql
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
> Assignee: Martijn Hendriks
> Fix For: core 1.4.6
>
> Attachments: JCR-1362.patch
>
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1362) DatabaseJournal improperly finds tables
in external schemas when used on Oracle
Posted by "Martijn Hendriks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Hendriks reassigned JCR-1362:
-------------------------------------
Assignee: Martijn Hendriks
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core, sql
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
> Assignee: Martijn Hendriks
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1362) DatabaseJournal improperly finds tables
in external schemas when used on Oracle
Posted by "Chris Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Schmidt updated JCR-1362:
-------------------------------
Component/s: sql
jackrabbit-core
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core, sql
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1362) DatabaseJournal improperly finds tables
in external schemas when used on Oracle
Posted by "Martijn Hendriks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Hendriks reassigned JCR-1362:
-------------------------------------
Assignee: (was: Martijn Hendriks)
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core, sql
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
> Fix For: core 1.4.6
>
> Attachments: JCR-1362.patch
>
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1362) DatabaseJournal improperly finds
tables in external schemas when used on Oracle
Posted by "Chris Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565980#action_12565980 ]
Chris Schmidt commented on JCR-1362:
------------------------------------
I have an implementation that I can include for this issue, but it also includes tablespace (for Oracle) and filegroup (for SqlServer) support. If those enhancements are OK to include, I will attach the patch.
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit
> Issue Type: Bug
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1362) DatabaseJournal improperly finds tables
in external schemas when used on Oracle
Posted by "Martijn Hendriks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Hendriks resolved JCR-1362.
-----------------------------------
Resolution: Fixed
Committed patch in revision: 686688
> DatabaseJournal improperly finds tables in external schemas when used on Oracle
> -------------------------------------------------------------------------------
>
> Key: JCR-1362
> URL: https://issues.apache.org/jira/browse/JCR-1362
> Project: Jackrabbit
> Issue Type: Bug
> Components: jackrabbit-core, sql
> Affects Versions: 1.3.3, 1.4
> Reporter: Chris Schmidt
> Assignee: Martijn Hendriks
> Attachments: JCR-1362.patch
>
>
> The DatabaseJournal currently calls database metadata to determine if the journal table has already been created. It uses the following code to do so:
> ResultSet rs = metaData.getTables(null, null, tableName, null);
> The Oracle driver sometimes will return the table if it is in another schema on the same database. Other DBMS code within JackRabbit has a specific Oracle version that handles this case. In order for the journal table to be properly created, Oracle databases will need the schema name included in the getTables() call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.