You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/13 00:59:45 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
dongjoon-hyun opened a new pull request #34874:
URL: https://github.com/apache/spark/pull/34874
### What changes were proposed in this pull request?
This PR aims to support K8s executor rolling policies.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
Yes, but this is a new feature.
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992163124
Could you review this please, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992306436
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50603/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992029203
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146111/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992283193
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50603/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992306436
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50603/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992248179
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50603/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992068205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992068205
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992057547
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34874:
URL: https://github.com/apache/spark/pull/34874#discussion_r767476322
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -145,6 +146,20 @@ private[spark] object Config extends Logging {
.checkValue(_ >= 0, "Interval should be non-negative")
.createWithDefault(0)
+ object ExecutorRollPolicy extends Enumeration {
+ val ID, ADD_TIME, TOTAL_GC_TIME, TOTAL_DURATION = Value
+ }
+
+ val EXECUTOR_ROLL_POLICY =
+ ConfigBuilder("spark.kubernetes.executor.rollPolicy")
+ .doc("Executor roll policy: Valid values are ID, ADD_TIME, TOTAL_GC_TIME (default), " +
+ "and TOTAL_DURATION")
Review comment:
Do we need to describe the meanings for each policy like the description does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34874:
URL: https://github.com/apache/spark/pull/34874#discussion_r767477976
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -145,6 +146,20 @@ private[spark] object Config extends Logging {
.checkValue(_ >= 0, "Interval should be non-negative")
.createWithDefault(0)
+ object ExecutorRollPolicy extends Enumeration {
+ val ID, ADD_TIME, TOTAL_GC_TIME, TOTAL_DURATION = Value
+ }
+
+ val EXECUTOR_ROLL_POLICY =
+ ConfigBuilder("spark.kubernetes.executor.rollPolicy")
+ .doc("Executor roll policy: Valid values are ID, ADD_TIME, TOTAL_GC_TIME (default), " +
+ "and TOTAL_DURATION")
Review comment:
Thank you for review. Sure! I'll add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992040445
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50586/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992211468
I addressed your comments, @viirya . Thank you for approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992213618
**[Test build #146129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146129/testReport)** for PR 34874 at commit [`7393e74`](https://github.com/apache/spark/commit/7393e742881954b3a709b28c32e7a79af9c9c7de).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992029203
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146111/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992021757
**[Test build #146111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146111/testReport)** for PR 34874 at commit [`2c385c7`](https://github.com/apache/spark/commit/2c385c7bca57e71537d1bd27a177a556400589af).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992255442
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146129/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992255442
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146129/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992213618
**[Test build #146129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146129/testReport)** for PR 34874 at commit [`7393e74`](https://github.com/apache/spark/commit/7393e742881954b3a709b28c32e7a79af9c9c7de).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992029038
**[Test build #146111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146111/testReport)** for PR 34874 at commit [`2c385c7`](https://github.com/apache/spark/commit/2c385c7bca57e71537d1bd27a177a556400589af).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class ExecutorRollPlugin extends SparkPlugin `
* `class ExecutorRollDriverPlugin extends DriverPlugin with Logging `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992021757
**[Test build #146111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146111/testReport)** for PR 34874 at commit [`2c385c7`](https://github.com/apache/spark/commit/2c385c7bca57e71537d1bd27a177a556400589af).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992224849
**[Test build #146129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146129/testReport)** for PR 34874 at commit [`7393e74`](https://github.com/apache/spark/commit/7393e742881954b3a709b28c32e7a79af9c9c7de).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34874:
URL: https://github.com/apache/spark/pull/34874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34874: [SPARK-37622][K8S] Support K8s executor rolling policy
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34874:
URL: https://github.com/apache/spark/pull/34874#issuecomment-992267540
Merged to master for Apache Spark 3.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org