You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Csaba Palfi <no...@github.com> on 2015/07/14 08:37:27 UTC

[jclouds-labs] Use boot2docker env vars as default docker properties (#189)

We can get working credentials to access docker if boot2docker is used as it generates certificates and sets up environment variables.

This way you can simply type `mvn -Plive integration-test` to run the live test if you have a boot2docker set up.

(One caveat is that I had to use the [regex-property plugin](http://www.mojohaus.org/build-helper-maven-plugin/regex-property-mojo.html) as the `DOCKER_HOST` env var set by boot2docker starts with `tcp://...` instead of `https://...`)
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/189

-- Commit Summary --

  * use boot2docker env vars as default docker properties

-- File Changes --

    M docker/pom.xml (28)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/189.patch
https://github.com/jclouds/jclouds-labs/pull/189.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/189

Re: [jclouds-labs] Use boot2docker env vars as default docker properties (#189)

Posted by Andrew Donald Kennedy <no...@github.com>.
> @@ -34,10 +34,10 @@
>    <packaging>bundle</packaging>
>  
>    <properties>
> -    <test.docker.endpoint>https://localhost:4243</test.docker.endpoint>
> +    <!--<test.docker.endpoint>${env.DOCKER_HOST}</test.docker.endpoint>-->

Why commented out"?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/189/files#r34791337

Re: [jclouds-labs] Use boot2docker env vars as default docker properties (#189)

Posted by Csaba Palfi <no...@github.com>.
Closed #189.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/189#event-357588138

Re: [jclouds-labs] Use boot2docker env vars as default docker properties (#189)

Posted by Csaba Palfi <no...@github.com>.
Now part of #188

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/189#issuecomment-121977582

Re: [jclouds-labs] Use boot2docker env vars as default docker properties (#189)

Posted by Csaba Palfi <no...@github.com>.
Just had another idea: we could totally use the [keytool plugin](http://www.mojohaus.org/keytool/keytool-maven-plugin/usage.html) to import the ca cert generated by boot2docker by default. That way you can just install boot2docker, clone the project and voilĂ : live tests work.

What do you think?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/189#issuecomment-121145535

Re: [jclouds-labs] Use boot2docker env vars as default docker properties (#189)

Posted by Csaba Palfi <no...@github.com>.
> @@ -34,10 +34,10 @@
>    <packaging>bundle</packaging>
>  
>    <properties>
> -    <test.docker.endpoint>https://localhost:4243</test.docker.endpoint>
> +    <!--<test.docker.endpoint>${env.DOCKER_HOST}</test.docker.endpoint>-->

It's now set by the property-regex maven plugin based on env.DOCKER_HOST. Can be removed so I did just that. :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/189/files#r34793155