[GitHub] [calcite] vlsi opened a new pull request #2410: Refine dependency declarations to better account for type annotations

[GitBox <gi...@apache.org>]

vlsi opened a new pull request #2410:
URL: https://github.com/apache/calcite/pull/2410


   The updated dependency-analysis analyzes type annotations much better.
   
   The command to analyze dependencies is
   
       ./gradlew -PenableDependencyAnalysis buildHealth
   
   The following warnings are still present (I believe they are false positives, however, the one regarding xerces is weird and we can either skip that dependency or declare it as implementation):
   
   https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/393
   ```
     Advice for project :core
     Existing dependencies which should be modified to be as indicated:
     - testImplementation("org.apache.commons:commons-dbcp2:2.6.0") (was implementation)
   ```
   
   https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/392
   ```
     Plugin advice:
     - java-library: this project has both java-library and org.jetbrains.kotlin.jvm applied, which is redundant. You can remove java-library
   ```
   
   https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/394
   In practice, xerces:xercesImpl is pulled to the `implementation` scope by spark->hadoop anyway, so there's no much sense in declaring xerces explicitly as we don't use it.
   
   ```
     Advice for project :spark
     Existing dependencies which should be modified to be as indicated:
     - implementation("xerces:xercesImpl:2.9.1") (was runtimeOnly)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] julianhyde commented on pull request #2410: Refine dependency declarations to better account for type annotations

[GitBox <gi...@apache.org>]

julianhyde commented on pull request #2410:
URL: https://github.com/apache/calcite/pull/2410#issuecomment-846184493


   Please log a JIRA case for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] asolimando commented on pull request #2410: [CALCITE-4618] Refine dependency declarations to better account for type annotations

[GitBox <gi...@apache.org>]

asolimando commented on pull request #2410:
URL: https://github.com/apache/calcite/pull/2410#issuecomment-917400670


   In the meantime, all the suspected false positives have been verified/fixed, so I think we are good to go now.
   
   PS: I did not know the tool, I wish there was a similar tool for Maven too, "manual" dependency management is hard!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org