You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/02 03:24:12 UTC
[GitHub] [doris] GoGim1 opened a new pull request, #13106: [docs] Fix wrong path in /docs folder
GoGim1 opened a new pull request, #13106:
URL: https://github.com/apache/doris/pull/13106
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13106: [docs] Fix wrong path in /docs folder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13106:
URL: https://github.com/apache/doris/pull/13106#issuecomment-1264542933
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] GoGim1 commented on pull request #13106: [fix] (docs) Fix wrong path in /docs folder
Posted by GitBox <gi...@apache.org>.
GoGim1 commented on PR #13106:
URL: https://github.com/apache/doris/pull/13106#issuecomment-1264675000
I found that if this PR was merged, images on [Doris's website](https://doris.apache.org/docs/summary/basic-summary) would get the wrong path since the website only copies the docs/images directory to the static/ instead of the docs/. Even though some images cannot be found when reading md files [directly on the github](https://github.com/apache/doris/tree/master/docs/zh-CN/docs) , I think it's better to close this PR. Any ideas?
@morningma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yukang-LIAN commented on pull request #13106: [fix] (docs) Fix wrong path in /docs folder
Posted by GitBox <gi...@apache.org>.
Yukang-LIAN commented on PR #13106:
URL: https://github.com/apache/doris/pull/13106#issuecomment-1264682776
> Even though some images cannot be found when reading md files [directly on the github](https://github.com/apache/doris/tree/master/docs/zh-CN/docs) , I think it's better to close this PR. Any ideas?
> @MorningMa
Maybe you @ the wrong guy. :joy: I think this is the right one. @morningman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org