You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/10/27 02:16:12 UTC
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Ian Maxon has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1315
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
ASTERIXDB-1710: Redo fails on WAIT log record
Simple fix :)
It would be best to have a test for this (and all other logtypes),
but the LogManager will have to be maniupulated into generating the record
for this specifically because the conditions upon which it happens naturally
are hard to encounter.
Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
---
M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/15/1315/1
diff --git a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
index 6eb758c..286fc16 100644
--- a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
+++ b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
@@ -405,6 +405,7 @@
case LogType.ABORT:
case LogType.FLUSH:
case LogType.UPSERT_ENTITY_COMMIT:
+ case LogType.WAIT:
case LogType.MARKER:
//do nothing
break;
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1315
to look at the new patch set (#2).
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
ASTERIXDB-1710: Redo fails on WAIT log record
Simple fix :)
It would be best to have a test for this (and all other logtypes),
but the LogManager will have to be maniupulated into generating the record
for this specifically because the conditions upon which it happens naturally
are hard to encounter.
Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
---
M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/15/1315/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
Patch Set 2:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1025/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3155/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has submitted this change and it was merged.
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
ASTERIXDB-1710: Redo fails on WAIT log record
Simple fix :)
It would be best to have a test for this (and all other logtypes),
but the LogManager will have to be maniupulated into generating the record
for this specifically because the conditions upon which it happens naturally
are hard to encounter.
Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1315
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <hu...@gmail.com>
---
M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
index 6eb758c..286fc16 100644
--- a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
+++ b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/RecoveryManager.java
@@ -405,6 +405,7 @@
case LogType.ABORT:
case LogType.FLUSH:
case LogType.UPSERT_ENTITY_COMMIT:
+ case LogType.WAIT:
case LogType.MARKER:
//do nothing
break;
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3152/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has posted comments on this change.
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3154/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1710: Redo fails on WAIT log record
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1710: Redo fails on WAIT log record
......................................................................
Patch Set 2: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1025/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1315
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4443b716bc791878fabbbf3b374fc7c7c592668f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No