You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by se...@apache.org on 2020/05/19 21:18:06 UTC

[openmeetings] branch feature/OPENMEETINGS-2356-move-close-icon-for-download-dialog created (now 4243c86)

This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a change to branch feature/OPENMEETINGS-2356-move-close-icon-for-download-dialog
in repository https://gitbox.apache.org/repos/asf/openmeetings.git.


      at 4243c86  OPENMEETINGS-2356 Move close icon on top of ui-titlebar so that mobile/touch can click it.

This branch includes the following new commits:

     new 4243c86  OPENMEETINGS-2356 Move close icon on top of ui-titlebar so that mobile/touch can click it.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[openmeetings] 01/01: OPENMEETINGS-2356 Move close icon on top of ui-titlebar so that mobile/touch can click it.

Posted by se...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a commit to branch feature/OPENMEETINGS-2356-move-close-icon-for-download-dialog
in repository https://gitbox.apache.org/repos/asf/openmeetings.git

commit 4243c861f528b4cc353baf0ff39a7da1804b1788
Author: Sebastian Wagner <se...@apache.org>
AuthorDate: Wed May 20 09:17:33 2020 +1200

    OPENMEETINGS-2356 Move close icon on top of ui-titlebar so that mobile/touch can click it.
---
 .../src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js  | 4 ++++
 openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css           | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
index 0770af9..6f0972f 100644
--- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
+++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/wb/raw-wb-area.js
@@ -411,6 +411,10 @@ var DrawWbArea = function() {
 					width: 350
 					, appendTo: '.room-block .wb-block'
 				});
+				// Fix to move the close icon on top of the .ui-dialog-titlebar cause otherwise 
+				// touch-events are broken and you won't be able to close the dialog
+				dlg.parent().find('.ui-dialog-titlebar-close').appendTo(dlg.parent());
+				
 			} catch (e) {
 				console.error(e);
 			}
diff --git a/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css b/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
index 6a4fd6a..cbfa1c7 100644
--- a/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
+++ b/openmeetings-web/src/main/webapp/css/theme_om/jquery-ui.css
@@ -595,8 +595,8 @@ button.ui-button::-moz-focus-inner {
 }
 .ui-dialog .ui-dialog-titlebar-close {
 	position: absolute;
-	right: .3em;
-	top: 50%;
+	right: 10px;
+    top: 20px;
 	width: 20px;
 	margin: -10px 0 0 0;
 	padding: 1px;