You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/07/07 11:56:37 UTC
[GitHub] [camel-k] phantomjinx opened a new pull request, #3423: Minor updates for bundle generation
phantomjinx opened a new pull request, #3423:
URL: https://github.com/apache/camel-k/pull/3423
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on a diff in pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on code in PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#discussion_r993381829
##########
script/Makefile:
##########
@@ -97,6 +100,13 @@ else
GOBIN=$(shell go env GOBIN)
endif
+# Support sed on mac osx
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on a diff in pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on code in PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#discussion_r993383376
##########
config/manifests/bases/camel-k.clusterserviceversion.yaml:
##########
@@ -22,16 +22,16 @@ metadata:
capabilities: Full Lifecycle
categories: Integration & Delivery
certified: "false"
- containerImage: docker.io/apache/camel-k:1.10.0-SNAPSHOT
- createdAt: 2022-05-31T12:18:30Z
+ containerImage: docker.io/apache/camel-k:X.Y.Z-SNAPSHOT
+ createdAt: 2022-07-05T16:41:32Z
description: Apache Camel K is a lightweight integration platform, born on Kubernetes,
with serverless superpowers.
- operators.operatorframework.io/builder: operator-sdk-v1.3.0
+ operators.operatorframework.io/builder: operator-sdk-v1.16.0
Review Comment:
operator-sdk version in Makefile is 1.16. For what its worth, this is just a notifying property of the version used to build the CSV bundle. It does not actually have any material effect on OLM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on a diff in pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on code in PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#discussion_r993383658
##########
config/manifests/bases/camel-k.clusterserviceversion.yaml:
##########
@@ -150,11 +150,11 @@ spec:
- email: users@camel.apache.org
name: The Apache Software Foundation
maturity: alpha
- minKubeVersion: 1.11.0
+ minKubeVersion: 1.14.0
Review Comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#issuecomment-1178909988
Added support for mac osx platform differences with sed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#issuecomment-1276119584
Tests failing due to e2e compilation error fixed in #3527.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#discussion_r917544211
##########
script/Makefile:
##########
@@ -97,6 +100,13 @@ else
GOBIN=$(shell go env GOBIN)
endif
+# Support sed on mac osx
Review Comment:
We discussed macOS support for the build scripts before and decided that macOS users use gnu-sed instead of the scripts taking care of the compatibility. See #3398
Please rever the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#issuecomment-1277199607
> Tests failing due to e2e compilation error fixed in #3527.
@phantomjinx Let's rebase it after the fix gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#issuecomment-1281846152
The last failing test is already fixed at main. Let's merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#discussion_r917544211
##########
script/Makefile:
##########
@@ -97,6 +100,13 @@ else
GOBIN=$(shell go env GOBIN)
endif
+# Support sed on mac osx
Review Comment:
We discussed macOS support for the build scripts before and decided that macOS users use gnu-sed instead of the scripts take care of the compatibility. See #3398
Please rever the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#discussion_r917657404
##########
config/manifests/bases/camel-k.clusterserviceversion.yaml:
##########
@@ -150,11 +150,11 @@ spec:
- email: users@camel.apache.org
name: The Apache Software Foundation
maturity: alpha
- minKubeVersion: 1.11.0
+ minKubeVersion: 1.14.0
Review Comment:
Do we want to change this? I'd keep it the original version unless there is a reason to change it.
##########
config/manifests/bases/camel-k.clusterserviceversion.yaml:
##########
@@ -22,16 +22,16 @@ metadata:
capabilities: Full Lifecycle
categories: Integration & Delivery
certified: "false"
- containerImage: docker.io/apache/camel-k:1.10.0-SNAPSHOT
- createdAt: 2022-05-31T12:18:30Z
+ containerImage: docker.io/apache/camel-k:X.Y.Z-SNAPSHOT
+ createdAt: 2022-07-05T16:41:32Z
description: Apache Camel K is a lightweight integration platform, born on Kubernetes,
with serverless superpowers.
- operators.operatorframework.io/builder: operator-sdk-v1.3.0
+ operators.operatorframework.io/builder: operator-sdk-v1.16.0
Review Comment:
Do we want to change this? I'd keep it the original version unless there is a reason to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#issuecomment-1281017092
Tests a lot more successful now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3423:
URL: https://github.com/apache/camel-k/pull/3423#issuecomment-1272665508
This PR has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3423: Minor updates for bundle generation
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3423:
URL: https://github.com/apache/camel-k/pull/3423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org