You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/04 15:01:28 UTC

[GitHub] [airflow] potiuk commented on issue #28723: Fix all deprecations for SQLAlchemy 2.0

potiuk commented on issue #28723:
URL: https://github.com/apache/airflow/issues/28723#issuecomment-1371038430

   > Just clarification. Our target support both 1.4.x and 2.0 or only 2.0?
   
   This is a good point, and I do not know the answer. I think it will entirely depend on:
   
   a) when we will do it
   b) how difficult it will be to keep compatibility
   c) get some indication of the adoption of 2.0 once it is out there
   
   I would refrain from trying to figure the answer before the final 2.0 release is out there - and possibly we should even wait for at least 2.0.1 or so, generally we should scout for stability indications. And then we should attempt to migrate and see how difficult it is to keep it compatible with both.
   
   If we will decide to support both, due to many differences and generally backwards incompatible release of sqlalchemy I would be only heppy with supporting both if we extend our test suite in CI and add another test matrix dimention - sqlalchemy_version (on top of backend + backend version, Python version) that we have now. 
   
   But we will also have to see if that is really needed, depending on how complex the fixing will be and how different the two versions are. If the differences are small, we can likely get-by without having the extra matrix dimension.
   
   If we see that differences are big, I think going 2.0-only is a better approach (and it basically means we will have to wait at least 6-10 months after release depending on adoption IMHO).
   
   There is absolutely no hurry with migration yet, 1.4 will be out there for a long while and it will be supported with bugfixes - so we do not have (and will not have for a while) particular need to migrate to 2.0. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org