[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2762: [GOBBLIN-908] Customized Progress to enable speculative execution

[GitBox <gi...@apache.org>]

ZihanLi58 commented on a change in pull request #2762: [GOBBLIN-908] Customized Progress to enable speculative execution
URL: https://github.com/apache/incubator-gobblin/pull/2762#discussion_r334694775
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/GobblinWorkUnitsInputFormat.java
 ##########
 @@ -203,7 +210,11 @@ public Text getCurrentValue()
     @Override
     public float getProgress()
         throws IOException, InterruptedException {
-      return (float) this.currentIdx / (float) this.totalPaths;
+      if (MRJobLauncher.isCustomizedProgressReportEnabled(properties)) {
+        return 0.0f;
 
 Review comment:
   Can we make the progress of finishing deserialize wu configurable, and return 
   (float) this.currentIdx / (float) this.totalPaths * progress_of_finishing_deserialize here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services