You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2026/07/01 22:40:01 UTC
[PR] [CI] Add Java Format CI check for pull requests [systemds]
Baunsgaard opened a new pull request, #2527:
URL: https://github.com/apache/systemds/pull/2527
Add a workflow that enforces dev/CodeStyle_eclipse.xml on the Java files changed by a pull request. It applies the Eclipse formatter (via formatter-maven-plugin) to only the changed src/main/java and src/test/java files and fails if that produces any diff, printing the required changes.
Also add dev/format-changed.sh, a helper that runs the same scoped formatting locally on the files you changed relative to the base branch (plus staged/unstaged/untracked edits). This avoids a bare `mvn formatter:format`, which would reformat the entire tree.
The check is scoped to the PR diff rather than the whole tree because the existing sources are not yet fully formatter-clean; this lets the codebase converge file-by-file without failing unrelated PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Add Java Format CI check for pull requests [systemds]
Posted by "janniklinde (via GitHub)" <gi...@apache.org>.
janniklinde commented on PR #2527:
URL: https://github.com/apache/systemds/pull/2527#issuecomment-4873997276
LGTM @Baunsgaard (except of course the probe code) :)
We may treat other codestyle policies similarly in future (e.g., private variable naming etc.). The main blocker was this exact failing for unchanged lines of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Add Java Format CI check for pull requests [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2527:
URL: https://github.com/apache/systemds/pull/2527#issuecomment-4860813593
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2527?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.67%. Comparing base ([`c099a2f`](https://app.codecov.io/gh/apache/systemds/commit/c099a2f09b9c882c33eda145c83c782a6d4a5c99?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a4648a3`](https://app.codecov.io/gh/apache/systemds/commit/a4648a31f19cdf597e6e286a39c034107b9e9a4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2527?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/sysds/runtime/DMLRuntimeException.java](https://app.codecov.io/gh/apache/systemds/pull/2527?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2FDMLRuntimeException.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvRE1MUnVudGltZUV4Y2VwdGlvbi5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2527 +/- ##
============================================
+ Coverage 71.66% 71.67% +0.01%
- Complexity 49338 49340 +2
============================================
Files 1580 1580
Lines 190516 190517 +1
Branches 37364 37364
============================================
+ Hits 136525 136556 +31
+ Misses 43464 43442 -22
+ Partials 10527 10519 -8
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/systemds/pull/2527?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Add Java Format CI check for pull requests [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard merged PR #2527:
URL: https://github.com/apache/systemds/pull/2527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Add Java Format CI check for pull requests [systemds]
Posted by "janniklinde (via GitHub)" <gi...@apache.org>.
janniklinde commented on PR #2527:
URL: https://github.com/apache/systemds/pull/2527#issuecomment-4863474763
I like this approach, but I'm wondering if it is too strict. It would imply that as a contributor, any slightly modified file must be completely reformatted by the PR. Second, different IDEs may apply slightly different formatting under the same xml so the only reliable way to reformat is using the exact same formatter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org