You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "tomaswolf (via GitHub)" <gi...@apache.org> on 2024/08/14 17:54:20 UTC

[I] NamedFactory uses wrong filter expression [mina-sshd]

tomaswolf opened a new issue, #582:
URL: https://github.com/apache/mina-sshd/issues/582

   ### Version
   
   2.14.0-SNAPSHOT
   
   ### Bug description
   
   Split off from #528:
   
   The implementations of `NamedFactory.setupBuiltinFactories()` and `NamedFactory.setupTransformedFactories()` use incorrect filter expressions to filter out algorithms not supported by the platform.
   
   They use the expression `ignoreUnsupported || f.isSupported()` and expect that to be `true` for supported factories, and `false` for unsupported ones.
   
   However, that is not correct. The parameter `ignoreUnsupported` actually implements the semantics of "include unsupported".
   
   This needs to be fixed. The correct expression would be `ignoreUnsupported ? f.isSupported() : true`, or `!ignoreUnsupported || f.isSupported()`.
   
   This bug exists in the code since 2015.
   
   ### Actual behavior
   
   `NamedFactory.setupBuiltinFactories(true, ...)` includes factories for unsupported algorithms in the returned list.
   
   ### Expected behavior
   
   `NamedFactory.setupBuiltinFactories(true, ...)` includes only factories for supported algorithms in the returned list.
   
   ### Relevant log output
   
   _No response_
   
   ### Other information
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

Re: [I] NamedFactory uses wrong filter expression [mina-sshd]

Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf closed issue #582: NamedFactory uses wrong filter expression
URL: https://github.com/apache/mina-sshd/issues/582


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org