You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "HeavenXin (via GitHub)" <gi...@apache.org> on 2023/05/10 14:10:36 UTC
[GitHub] [superset] HeavenXin opened a new pull request, #24006: Fixed that there is no copy filter when copying the dashboard
HeavenXin opened a new pull request, #24006:
URL: https://github.com/apache/superset/pull/24006
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I found that after I selected the copy slice when I was copying the dashboard,
the new dashboard does not have the filter of the original dashboard.
Although there is a relevant copy default_filter in the code, it does not take effect,
so I fixed it. I am not sure this is a bug, please Community maintainers view
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
before:
https://github.com/apache/superset/assets/40172777/8ee17250-f362-4a59-bda3-5c3ca8cb79a7
after:
https://github.com/apache/superset/assets/40172777/f1d3a2e9-7fac-408a-9b0d-c858334df117
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: that there is no copy filter when copying the dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24006:
URL: https://github.com/apache/superset/pull/24006#issuecomment-1960495169
Hi there @HeavenXin - sorry this slipped under everyone's radar. Is this still relevant/needed? If so, the PR needs a rebase, but hopefully we can get it across the finish line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: that there is no copy filter when copying the dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24006:
URL: https://github.com/apache/superset/pull/24006#issuecomment-2536953831
Converting this to draft for now since it's still in need of a rebase. Please feel free to update it, or it may be closed in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: that there is no copy filter when copying the dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24006:
URL: https://github.com/apache/superset/pull/24006#issuecomment-2791174691
This has been in draft mode awaiting updates since December. It doesn't seem likely to become ready for merge at this point, so we'll close this PR to help keep the backlog manageable. Please feel free to reopen (or ping me to) if you still want to get this through. We appreciate the contribution in either case!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: that there is no copy filter when copying the dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #24006: fix: that there is no copy filter when copying the dashboard
URL: https://github.com/apache/superset/pull/24006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org