You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ag-ramachandran (via GitHub)" <gi...@apache.org> on 2026/02/11 12:42:01 UTC

[PR] * Add support for NULL / IS NOT NULL operator [superset]

ag-ramachandran opened a new pull request, #37890:
URL: https://github.com/apache/superset/pull/37890

   ** Generated notes **
   
   This pull request enhances the Kusto engine spec in Superset by adding support for KQL-specific features and improving query handling. The main changes include custom handling for null filters, new methods for epoch-to-datetime conversions, improved processing of ARRAY wrappers in queries, and corresponding unit tests to ensure correctness.
   
   **KQL-specific query and filter handling:**
   
   * Added a `handle_null_filter` method to generate KQL-compliant null and not-null filter expressions using `isnull` and `isnotnull` functions.
   * Implemented an `execute` method that processes queries to remove unnecessary `ARRAY()` wrappers around bracket-quoted identifiers before execution.
   
   **Date/time conversion enhancements:**
   
   * Added `epoch_to_dttm` and `epoch_ms_to_dttm` methods to provide KQL templates for converting epoch seconds and milliseconds to datetime.
   
   **Type mapping improvements:**
   
   * Introduced a `column_type_mappings` entry to map Kusto array types to string types in Superset.
   
   **Testing and validation:**
   
   * Added unit tests for the new null filter handling, epoch-to-datetime conversion methods, and the `execute` method’s ARRAY processing logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-4116063815

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #37890:
URL: https://github.com/apache/superset/pull/37890#discussion_r2985810114


##########
superset/db_engine_specs/kusto.py:
##########
@@ -213,3 +266,33 @@ def convert_dttm(
             return f"""datetime({dttm.isoformat(timespec="microseconds")})"""
 
         return None
+
+    @classmethod
+    def execute(
+        cls,
+        cursor: Any,
+        query: str,
+        database: "Database",
+        **kwargs: Any,
+    ) -> None:
+        """
+        Execute a KQL query, fixing ARRAY() wrappers around
+        bracket-quoted identifiers.
+
+        Example:
+            ARRAY(["age"]) -> ["age"]
+            ARRAY(["user_name"]) -> ["user_name"]
+        """
+        # Replace ARRAY(["identifier"]) with ["identifier"]
+        processed_query, num_replacements = re.subn(
+            r'ARRAY\(\[("(?:[^"\\]|\\.)*")\]\)',

Review Comment:
   **Suggestion:** The `ARRAY(...)` cleanup regex can rewrite substrings inside longer identifiers/functions (for example `PACK_ARRAY(["x"])`), producing invalid KQL like `PACK_["x"]`. Restrict the match so `ARRAY` is treated as a standalone token before replacing. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ KQL SQL Lab queries can be text-corrupted.
   - ⚠️ Affects `kustokql` execution path before cursor execution.
   ```
   </details>
   
   ```suggestion
               r'(?<![A-Za-z0-9_])ARRAY\(\[("(?:[^"\\]|\\.)*")\]\)',
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Execute the KQL engine path by calling `KustoKqlEngineSpec.execute()` in
   `superset/db_engine_specs/kusto.py:271`; this method is used by SQL execution flows
   (`superset/sql/execution/executor.py:63`, `superset/models/core.py:43`, and SQL Lab via
   `superset/db_engine_specs/base.py:1533-1545`).
   
   2. Pass a query containing a longer token ending with `ARRAY(...)`, e.g. `T | extend y =
   PACK_ARRAY(["x"]) | take 1`, into `execute()` at
   `superset/db_engine_specs/kusto.py:287-291`.
   
   3. The current regex `ARRAY\(\[...\]\)` at `kusto.py:288` matches inside
   `PACK_ARRAY(["x"])` and rewrites only that substring; verified by execution: output
   becomes `PACK_["x"]` (1 replacement).
   
   4. `super().execute()` (`superset/db_engine_specs/base.py:2107-2141`) then sends the
   corrupted query string to `cursor.execute(query)`, so query text is modified incorrectly
   before DB execution.
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/db_engine_specs/kusto.py
   **Line:** 288:288
   **Comment:**
   	*Logic Error: The `ARRAY(...)` cleanup regex can rewrite substrings inside longer identifiers/functions (for example `PACK_ARRAY(["x"])`), producing invalid KQL like `PACK_["x"]`. Restrict the match so `ARRAY` is treated as a standalone token before replacing.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37890&comment_hash=47f4298559c0d06b3a6222cff05c174ee003ae1d7186136579dd7d84f08f942c&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37890&comment_hash=47f4298559c0d06b3a6222cff05c174ee003ae1d7186136579dd7d84f08f942c&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #37890:
URL: https://github.com/apache/superset/pull/37890#discussion_r2798911342


##########
superset/db_engine_specs/kusto.py:
##########
@@ -201,6 +212,46 @@ def get_dbapi_exception_mapping(cls) -> dict[type[Exception], type[Exception]]:
             kusto_exceptions.ProgrammingError: SupersetDBAPIProgrammingError,
         }
 
+    @classmethod
+    def handle_null_filter(
+        cls,
+        sqla_col: Any,
+        op: Any,
+    ) -> Any:
+        """
+        Handle null/not null filter operations for KQL.
+
+        In KQL, null checks use functions:
+        - isnull(col) for IS NULL
+        - isnotnull(col) for IS NOT NULL
+
+        :param sqla_col: SQLAlchemy column element
+        :param op: Filter operator (IS_NULL or IS_NOT_NULL)
+        :return: SQLAlchemy expression for the null filter
+        """
+        from superset.utils import core as utils
+
+        if op == utils.FilterOperator.IS_NULL:
+            return text(f"isnull({sqla_col})")
+        if op == utils.FilterOperator.IS_NOT_NULL:
+            return text(f"isnotnull({sqla_col})")

Review Comment:
   **Suggestion:** Building the null filter with `text(f"isnull({sqla_col})")` and `text(f"isnotnull({sqla_col})")` relies on the string representation of a SQLAlchemy column, which is dialect-agnostic and can produce incorrectly quoted or aliased identifiers in KQL, bypassing SQLAlchemy's compiler and potentially resulting in invalid queries or broken bindings; instead, construct the expression using SQLAlchemy function objects so the dialect can render it correctly. [logic error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ❌ KQL IS NULL filters may fail for quoted identifiers.
   - ❌ KQL IS NOT NULL filters may fail for complex expressions.
   - ⚠️ Dashboards using such filters can show empty/error states.
   - ⚠️ Inconsistent identifier rendering between filters and main query.
   ```
   </details>
   
   ```suggestion
           from sqlalchemy import func
   
           if op == utils.FilterOperator.IS_NULL:
               return func.isnull(sqla_col)
           if op == utils.FilterOperator.IS_NOT_NULL:
               return func.isnotnull(sqla_col)
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Configure a Kusto KQL database in Superset using the `KustoKqlEngineSpec` engine
   (`superset/db_engine_specs/kusto.py`, class `KustoKqlEngineSpec` where
   `handle_null_filter` is defined around lines 215–239).
   
   2. Create or edit a chart in Explore that uses this KQL-backed dataset and add a filter
   with operator `IS NULL` (or `IS NOT NULL`) on a column whose SQLAlchemy object is not a
   simple bare identifier, e.g. a column with spaces or reserved words that requires
   quoting/aliasing by the Kusto dialect.
   
   3. When the query is built, Superset's generic query-building code (in the engine-spec
   layer defined in `superset/db_engine_specs/base.py`, which delegates null-handling to
   `handle_null_filter`) calls `KustoKqlEngineSpec.handle_null_filter(...)` with the
   SQLAlchemy column object `sqla_col` and the appropriate `FilterOperator`.
   
   4. `handle_null_filter` at `superset/db_engine_specs/kusto.py:215-239` constructs
   `text(f"isnull({sqla_col})")` / `text(f"isnotnull({sqla_col})")`, which uses
   `str(sqla_col)` under SQLAlchemy's default compilation instead of the Kusto dialect; this
   can yield incorrectly quoted or mismatched identifiers in the final KQL string, causing
   Kusto to return a syntax or "unknown column" error when the chart is run, whereas using
   `func.isnull(sqla_col)` / `func.isnotnull(sqla_col)` would let the Kusto dialect render
   the expression consistently with the rest of the query.
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/db_engine_specs/kusto.py
   **Line:** 233:237
   **Comment:**
   	*Logic Error: Building the null filter with `text(f"isnull({sqla_col})")` and `text(f"isnotnull({sqla_col})")` relies on the string representation of a SQLAlchemy column, which is dialect-agnostic and can produce incorrectly quoted or aliased identifiers in KQL, bypassing SQLAlchemy's compiler and potentially resulting in invalid queries or broken bindings; instead, construct the expression using SQLAlchemy function objects so the dialect can render it correctly.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37890&comment_hash=3243fc2ca1ba321df511f2108fac1b372b6515d25c1b080328356ad534f4458f&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37890&comment_hash=3243fc2ca1ba321df511f2108fac1b372b6515d25c1b080328356ad534f4458f&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-5041354707

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-4163295150

   Nice! Let me know when this is ready for review again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on code in PR #37890:
URL: https://github.com/apache/superset/pull/37890#discussion_r2982043507


##########
superset/db_engine_specs/kusto.py:
##########
@@ -213,3 +266,33 @@ def convert_dttm(
             return f"""datetime({dttm.isoformat(timespec="microseconds")})"""
 
         return None
+
+    @classmethod
+    def execute(
+        cls,
+        cursor: Any,
+        query: str,
+        database: "Database",
+        **kwargs: Any,
+    ) -> None:
+        """
+        Execute a KQL query, fixing ARRAY() wrappers around
+        bracket-quoted identifiers.
+
+        Example:
+            ARRAY(["age"]) -> ["age"]
+            ARRAY(["user_name"]) -> ["user_name"]
+        """
+        # Replace ARRAY(["identifier"]) with ["identifier"]
+        processed_query, num_replacements = re.subn(

Review Comment:
   We already have a [tokenizer for KQL](https://github.com/apache/superset/blob/89d1b80ce7d22c9c0a90fbc4db0455c16e896f72/superset/sql/parse.py#L977), let's use it here instead of relying on regular expressions. Something like this should work:
   
   ```python
   from superset.sql.parse import KQLTokenType, tokenize_kql
   
   
   def strip_array_brackets(kql: str) -> str:
       tokens = tokenize_kql(kql)
   
       OPENING_BRACKET = [
           (KQLTokenType.WORD, "ARRAY"),
           (KQLTokenType.OTHER, "("),
           (KQLTokenType.OTHER, "["),
       ]
       CLOSING_BRACKET = [(KQLTokenType.OTHER, "]"), (KQLTokenType.OTHER, ")")]
   
       to_remove = set()
       for i in range(len(tokens)):
           if tokens[i : i + 3] == OPENING_BRACKET:
               to_remove.add(i)
               to_remove.add(i + 1)
           elif tokens[i : i + 2] == CLOSING_BRACKET:
               to_remove.add(i + 1)
   
       tokens = [token for i, token in enumerate(tokens) if i not in to_remove]
   
       return "".join(val for _, val in tokens)
   ```
   
   This could be improved to ensure the number of opening brackets match the number of closing brackets, or that we only strip them when the tokens between them are of a certain type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #37890:
URL: https://github.com/apache/superset/pull/37890#discussion_r2979500712


##########
tests/unit_tests/db_engine_specs/test_kusto.py:
##########
@@ -139,3 +139,72 @@ def test_timegrain_expressions(in_duration: str, expected_result: str) -> None:
         col=col, pdf=None, time_grain=in_duration
     )
     assert str(actual_result) == expected_result
+
+
+def test_epoch_to_dttm() -> None:
+    """
+    Test that KQL engine spec returns correct epoch to datetime conversion template.
+    """
+    result = KustoKqlEngineSpec.epoch_to_dttm()
+    assert result == "unixtime_seconds_todatetime({col})"
+
+
+def test_epoch_ms_to_dttm() -> None:
+    """
+    Test that KQL engine spec returns correct epoch milliseconds to
+    datetime conversion template.
+    """
+    result = KustoKqlEngineSpec.epoch_ms_to_dttm()
+    assert result == "unixtime_milliseconds_todatetime({col})"
+
+
+def test_handle_null_filter() -> None:
+    """
+    Test that KQL engine spec uses isnull/isnotnull functions for null filters.
+    """
+    from superset.utils.core import FilterOperator
+
+    test_col = column("test_column")
+
+    # Test IS_NULL - should return isnull(col)
+    result_null = KustoKqlEngineSpec.handle_null_filter(
+        test_col, FilterOperator.IS_NULL
+    )
+    assert str(result_null) == "isnull(test_column)"
+
+    # Test IS_NOT_NULL - should return isnotnull(col)
+    result_not_null = KustoKqlEngineSpec.handle_null_filter(
+        test_col, FilterOperator.IS_NOT_NULL
+    )
+    assert str(result_not_null) == "isnotnull(test_column)"
+
+    # Test invalid operator - should raise ValueError
+    with pytest.raises(ValueError, match="Invalid null filter operator"):
+        KustoKqlEngineSpec.handle_null_filter(test_col, "INVALID_OPERATOR")

Review Comment:
   The invalid-operator test passes a `str` to `handle_null_filter`, but the method is typed to accept `FilterOperator`. Other engine spec tests suppress this with `# type: ignore[arg-type]` to keep mypy happy; consider adding the same here to avoid CI typing failures.
   ```suggestion
           KustoKqlEngineSpec.handle_null_filter(test_col, "INVALID_OPERATOR")  # type: ignore[arg-type]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "ag-ramachandran (via GitHub)" <gi...@apache.org>.
ag-ramachandran commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-4116095151

   Hello @betodealmeida , @Antonio-RiveroMartnez , would it be possible for you to have look when you get some time. Thanks in advance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-3891312379

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #37890:
URL: https://github.com/apache/superset/pull/37890#discussion_r2979465645


##########
superset/db_engine_specs/kusto.py:
##########
@@ -213,3 +265,31 @@ def convert_dttm(
             return f"""datetime({dttm.isoformat(timespec="microseconds")})"""
 
         return None
+
+    @classmethod
+    def execute(
+        cls,
+        cursor: Any,
+        query: str,
+        database: "Database",
+        **kwargs: Any,
+    ) -> None:
+        """
+        Execute a KQL query, fixing ARRAY() wrappers around
+        bracket-quoted identifiers.
+
+        Example:
+            ARRAY(["age"]) -> ["age"]
+            ARRAY(["user_name"]) -> ["user_name"]
+        """
+        logger.debug("execute: input query: %s", query)
+
+        # Replace ARRAY(["identifier"]) with ["identifier"]
+        processed_query = re.sub(
+            r'ARRAY\(\[("(?:[^"\\]|\\.)*")\]\)',
+            r"[\1]",
+            query,
+        )
+
+        logger.debug("execute: processed query: %s", processed_query)
+        super().execute(cursor, processed_query, database, **kwargs)

Review Comment:
   The new debug logs print full raw/processed query strings. Queries can include sensitive literals (emails, tokens, customer identifiers) and can be large, so logging them can create data-exposure and log-volume risks when debug logging is enabled. Consider removing these logs, or logging only a boolean/metric (e.g., whether a rewrite occurred / number of replacements) and/or a safely-truncated/redacted version of the query.



##########
superset/db_engine_specs/kusto.py:
##########
@@ -28,8 +29,13 @@
     SupersetDBAPIOperationalError,
     SupersetDBAPIProgrammingError,
 )
+
+if TYPE_CHECKING:
+    from superset.models.core import Database

Review Comment:
   Import grouping: the `if TYPE_CHECKING:` block is immediately followed by a non-conditional import (`from superset.sql.parse import LimitMethod`) without a separating blank line. This is atypical in this codebase (and may trip isort/ruff import formatting) because it visually reads as though the next import is part of the TYPE_CHECKING block. Add a blank line after the TYPE_CHECKING block (or reorder imports per isort).
   ```suggestion
       from superset.models.core import Database
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #37890:
URL: https://github.com/apache/superset/pull/37890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #37890:
URL: https://github.com/apache/superset/pull/37890#discussion_r2848858188


##########
superset/db_engine_specs/kusto.py:
##########
@@ -213,3 +264,35 @@ def convert_dttm(
             return f"""datetime({dttm.isoformat(timespec="microseconds")})"""
 
         return None
+
+    @classmethod
+    def execute(
+        cls,
+        cursor: Any,
+        query: str,
+        database: "Database",
+        **kwargs: Any,
+    ) -> None:
+        """
+        Execute a KQL query, fixing ARRAY() wrappers around
+        bracket-quoted identifiers.
+
+        Example:
+            ARRAY(["age"]) -> ["age"]
+            ARRAY(["user_name"]) -> ["user_name"]
+        """
+        import logging
+        import re
+
+        logger = logging.getLogger(__name__)
+        logger.debug("execute: input query: %s", query)
+
+        # Replace ARRAY(["identifier"]) with ["identifier"]
+        processed_query = re.sub(
+            r'ARRAY\(\[("[^"]+")\]\)',

Review Comment:
   The regex pattern `r'ARRAY\(\[("[^"]+")\]\)'` has a potential issue. It uses `[^"]+` which matches one or more non-quote characters, but this won't handle edge cases properly:
   
   1. It won't match identifiers with escaped quotes inside them (e.g., `["col\"name"]`)
   2. It requires at least one character between quotes, so `ARRAY([""])` wouldn't match
   3. The pattern is too restrictive for bracket-quoted identifiers in KQL
   
   Consider using a more robust pattern like `r'ARRAY\(\[("(?:[^"\\]|\\.)*")\]\)'` which handles escaped characters within quotes, or if identifiers can't contain quotes, use `r'ARRAY\(\[("[^"]*")\]\)'` to allow empty identifiers.
   ```suggestion
               r'ARRAY\(\[("(?:[^"\\]|\\.)*")\]\)',
   ```



##########
superset/db_engine_specs/kusto.py:
##########
@@ -201,6 +212,46 @@ def get_dbapi_exception_mapping(cls) -> dict[type[Exception], type[Exception]]:
             kusto_exceptions.ProgrammingError: SupersetDBAPIProgrammingError,
         }
 
+    @classmethod
+    def handle_null_filter(
+        cls,
+        sqla_col: Any,
+        op: Any,
+    ) -> Any:
+        """
+        Handle null/not null filter operations for KQL.
+
+        In KQL, null checks use functions:
+        - isnull(col) for IS NULL
+        - isnotnull(col) for IS NOT NULL
+
+        :param sqla_col: SQLAlchemy column element
+        :param op: Filter operator (IS_NULL or IS_NOT_NULL)
+        :return: SQLAlchemy expression for the null filter
+        """
+        from superset.utils import core as utils
+
+        if op == utils.FilterOperator.IS_NULL:
+            return text(f"isnull({sqla_col})")
+        if op == utils.FilterOperator.IS_NOT_NULL:
+            return text(f"isnotnull({sqla_col})")

Review Comment:
   Using f-string interpolation with `text()` bypasses SQLAlchemy's query compilation and parameter binding mechanisms. While sqla_col is a SQLAlchemy ColumnElement, converting it to a string with str() and interpolating it directly can lead to issues:
   
   1. It doesn't respect SQLAlchemy's dialect-specific quoting rules
   2. If sqla_col contains complex expressions or subqueries, the string representation may not be syntactically valid in all contexts
   3. It prevents SQLAlchemy from applying proper escaping for the target database
   
   Use `literal_column()` instead, which preserves SQLAlchemy's expression compilation system while generating raw SQL/KQL. For example: `return literal_column(f"isnull({sqla_col})")`. This is safer and more maintainable as it works with SQLAlchemy's query builder rather than bypassing it.



##########
superset/db_engine_specs/kusto.py:
##########
@@ -201,6 +212,46 @@ def get_dbapi_exception_mapping(cls) -> dict[type[Exception], type[Exception]]:
             kusto_exceptions.ProgrammingError: SupersetDBAPIProgrammingError,
         }
 
+    @classmethod
+    def handle_null_filter(
+        cls,
+        sqla_col: Any,
+        op: Any,

Review Comment:
   The type hint for the `op` parameter should be `utils.FilterOperator` (or fully qualified as seen in the base class) instead of `Any` to maintain type safety and consistency with the base class definition. This ensures proper type checking and makes the expected parameter type clear.



##########
superset/db_engine_specs/kusto.py:
##########
@@ -213,3 +264,35 @@ def convert_dttm(
             return f"""datetime({dttm.isoformat(timespec="microseconds")})"""
 
         return None
+
+    @classmethod
+    def execute(
+        cls,
+        cursor: Any,
+        query: str,
+        database: "Database",
+        **kwargs: Any,
+    ) -> None:
+        """
+        Execute a KQL query, fixing ARRAY() wrappers around
+        bracket-quoted identifiers.
+
+        Example:
+            ARRAY(["age"]) -> ["age"]
+            ARRAY(["user_name"]) -> ["user_name"]
+        """
+        import logging
+        import re

Review Comment:
   The imports for `logging` and `re` should be moved to the module level rather than being imported within the method. The `re` module is already imported at line 17, so the redundant import on line 285 should be removed. The `logging` module should be imported at the top of the file alongside other module-level imports, following the codebase convention seen in other db_engine_specs files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-3889107521

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 4bd50a18476b2e44fc527388c76a9c4bdebe0c6c |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/698d7f622daf2a0008a2369f |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-37890--superset-docs-preview.netlify.app](https://deploy-preview-37890--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTM3ODkwLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.Dn6ybcjOOLdMkh-1rXRV0iG7-R8iYh7stGWG9emr2VI)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-37890--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-3884246705

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/37890?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `42.30769%` with `15 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.91%. Comparing base ([`76d897e`](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e720b2b`](https://app.codecov.io/gh/apache/superset/commit/e720b2b864c824802d876d57d93d97052367e6ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 3714 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/37890?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/db\_engine\_specs/kusto.py](https://app.codecov.io/gh/apache/superset/pull/37890?src=pr&el=tree&filepath=superset%2Fdb_engine_specs%2Fkusto.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t1c3RvLnB5) | 42.30% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/37890?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #37890      +/-   ##
   ==========================================
   + Coverage   60.48%   65.91%   +5.42%     
   ==========================================
     Files        1931      668    -1263     
     Lines       76236    51311   -24925     
     Branches     8568     5775    -2793     
   ==========================================
   - Hits        46114    33821   -12293     
   + Misses      28017    16096   -11921     
   + Partials     2105     1394     -711     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/37890/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/37890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.49% <42.30%> (-7.66%)` | :arrow_down: |
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/37890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/37890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.51% <42.30%> (-12.29%)` | :arrow_down: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/37890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.90% <42.30%> (+2.39%)` | :arrow_up: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/37890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.24% <42.30%> (?)` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/37890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+42.36%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/37890?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] * Add support for NULL / IS NOT NULL operator [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-3884188608

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #37890:
URL: https://github.com/apache/superset/pull/37890#discussion_r2793193001


##########
tests/unit_tests/db_engine_specs/test_kusto.py:
##########
@@ -139,3 +139,71 @@ def test_timegrain_expressions(in_duration: str, expected_result: str) -> None:
         col=col, pdf=None, time_grain=in_duration
     )
     assert str(actual_result) == expected_result
+
+
+def test_epoch_to_dttm() -> None:
+    """
+    Test that KQL engine spec returns correct epoch to datetime conversion template.
+    """
+    result = KustoKqlEngineSpec.epoch_to_dttm()
+    assert result == "unixtime_seconds_todatetime({col})"
+
+
+def test_epoch_ms_to_dttm() -> None:
+    """
+    Test that KQL engine spec returns correct epoch milliseconds to datetime conversion template.
+    """
+    result = KustoKqlEngineSpec.epoch_ms_to_dttm()
+    assert result == "unixtime_milliseconds_todatetime({col})"
+
+
+def test_handle_null_filter() -> None:
+    """
+    Test that KQL engine spec uses isnull/isnotnull functions for null filters.
+    """
+    from superset.utils.core import FilterOperator
+
+    test_col = column("test_column")
+
+    # Test IS_NULL - should return isnull(col)
+    result_null = KustoKqlEngineSpec.handle_null_filter(
+        test_col, FilterOperator.IS_NULL
+    )
+    assert str(result_null) == "isnull(test_column)"
+
+    # Test IS_NOT_NULL - should return isnotnull(col)
+    result_not_null = KustoKqlEngineSpec.handle_null_filter(
+        test_col, FilterOperator.IS_NOT_NULL
+    )
+    assert str(result_not_null) == "isnotnull(test_column)"
+
+    # Test invalid operator - should raise ValueError
+    with pytest.raises(ValueError, match="Invalid null filter operator"):
+        KustoKqlEngineSpec.handle_null_filter(test_col, "INVALID_OPERATOR")
+
+
+@pytest.mark.parametrize(
+    "raw_query,expected_query",

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Incorrect parametrize argument type</b></div>
   <div id="fix">
   
   Change the first argument of `@pytest.mark.parametrize` from a string to a tuple: `("raw_query", "expected_query")` instead of `"raw_query,expected_query"`.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ````suggestion
       ("raw_query", "expected_query"),
   ````
   
   </div>
   </details>
   
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #5fbda0</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-3889406072

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-4124495374

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(KustoKQL): Add support for NULL / IS NOT NULL operator [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #37890:
URL: https://github.com/apache/superset/pull/37890#issuecomment-4732469137

   Rebased the PR to see how CI does. Maybe we'll get lucky... but we'd love to see this through if you can help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org