[GitHub] [iotdb] LebronAl commented on a change in pull request #2222: [Distributed] fix session cache leader interface and docs

[GitBox <gi...@apache.org>]

LebronAl commented on a change in pull request #2222:
URL: https://github.com/apache/iotdb/pull/2222#discussion_r559334091



##########
File path: session/src/main/java/org/apache/iotdb/session/SessionConnection.java
##########
@@ -67,6 +67,9 @@
   private ZoneId zoneId;
   private EndPoint endPoint;
 
+  //TestOnly
+  public SessionConnection(){}

Review comment:
       Testonly's anonation is currently in the server module. The session module does not currently have a dependency on the server module, so I don't think it would be appropriate to introduce a dependency just for this purpose. As for creating a new testonly anotation in the session module, I think it's a bit redundant because it's the only one we've used so far. But if you think it's worth creating a new anonation in the Session Module, I'll do it. What your opinion?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org