[jira] [Commented] (SOLR-13308) Move SystemPropertiesRestoreRule to SolrTestCase

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788017#comment-16788017 ] 

Erick Erickson commented on SOLR-13308:
---------------------------------------

In particular, IDK whether doing this in the base class will also reset values in the subclasses.

> Move SystemPropertiesRestoreRule to SolrTestCase
> ------------------------------------------------
>
>                 Key: SOLR-13308
>                 URL: https://issues.apache.org/jira/browse/SOLR-13308
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (9.0), 8.1
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>
> [~krisden] just traced flaky HDFS tests to not clearing sysprops, see the discussion at SOLR-13297.
> Part of SOLR-13268 is to derive all Solr test classes from SolrTestCase.
> Once that's pushed, does it make sense to put that rule in SolrTestCase so it gets performed automagically so this kind of error doesn't creep back in?
> I don't know the details of how that rule is implemented or whether this makes sense at that level but wanted to discuss.
> I've assigned it to myself, but that's just so I don't lose track of it, but anyone else who wants to pick it up please feel free.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org