You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ErnieAllen <gi...@git.apache.org> on 2018/06/02 17:42:03 UTC
[GitHub] qpid-dispatch pull request #312: Add console to build
GitHub user ErnieAllen opened a pull request:
https://github.com/apache/qpid-dispatch/pull/312
Add console to build
Please review the CMakeLists.txt
The console build will:
- run lint on javascript and typescript files
- convert typescript files to javascript
- run babel so I can use modern javascript syntax and still run on older browsers
- concat all 3rd party .css files into a single file
- concat all 3rd party .js files into a single file
- concat all console .js files into a single file
- minimize all .css and .js files
- copy build artefacts into dist/ folder for installing
Running make install will copy all built and static files to the console install dir.
Notes:
- I'm using file (GLOB ...) to get a list of the files to be built. If new files are added later, cmake won't know about them and may skip building the console. This shouldn't be a problem for production builds, but for day to day development builds it may be necessary to run cmake . or touch CMakeLists.txt before running make. This is not a problem specific to the console build.
- To build the console, npm must be installed. Should I move the line that adds the cmake 'option' to build the console inside the check if npm is installed?
- To build the console, gulp-cli has to be install globally. This is done with the 'sudo npm install -g gulp-cli' command. This can't be put into the build script since I can't assume sudo permissions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ErnieAllen/qpid-dispatch master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #312
----
commit b622fa8f07cbd354424c5db474844513d7e6df97
Author: Ernest Allen <ea...@...>
Date: 2018-06-02T17:09:29Z
DISPATCH-1017 Add console to make build
commit dcea91d2cd3c65416a9f0f40092b55999bfbba4e
Author: Ernest Allen <ea...@...>
Date: 2018-06-02T17:10:38Z
DISPATCH-1017 Add new typescript lint files for building console
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #312: DISPATCH-1017 Add console to build
Posted by ErnieAllen <gi...@git.apache.org>.
Github user ErnieAllen closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/312
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org