You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/02/24 23:56:56 UTC

[GitHub] [geode] jinmeiliao commented on pull request #7395: GEODE-10084: CliFunction should handle all throwable

jinmeiliao commented on pull request #7395:
URL: https://github.com/apache/geode/pull/7395#issuecomment-1050374418


   > The new `ImportDataFunctionTest` does not test `ImportDataFunction` at all. It tests `CliFunction`. So move this test from `ImportDataFunctionTest` to `CliFunctionTest`. And change it so that instead of spying the unit under test, it creates a derived class where `executeFunction()` does nothing but throw.
   > 
   > Then add unit tests for the new and changed functionality in `ImportDataFunction`.
   
   Oh, yeah, that's true. fixed. I don't have a test for `ImporrtDataFunction` since I don't know what kind of test would make sense for the little change I made besides the test I already wrote.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org