You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/04/01 05:06:19 UTC
[kudu-CR](branch-1.17.x) KUDU-1945 Auto-incrementing column feature flag
Hello Kudu Jenkins, Wenzhe Zhou,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19676
to review the following change.
Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................
KUDU-1945 Auto-incrementing column feature flag
This patch adds the flag "--master_support_auto_incrementing_column" to
guard the auto-incrementing column feature. It prohibits users to create
table with non-unique primary key. The default value for the flag is set
to true in this patch. The verification happens on the RPC level. If the
server has the feature turned off, or the server is older compared to
the client - doesn't have the auto-incrementing feature -, the request
gets rejected in both cases.
Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Reviewed-on: http://gerrit.cloudera.org:8080/19523
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 7fafdd2803a2c747faa6789a1921d51186edfb6e)
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
8 files changed, 64 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/19676/1
--
To view, visit http://gerrit.cloudera.org:8080/19676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19676
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR](branch-1.17.x) KUDU-1945 Auto-incrementing column feature flag
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19676 )
Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................
KUDU-1945 Auto-incrementing column feature flag
This patch adds the flag "--master_support_auto_incrementing_column" to
guard the auto-incrementing column feature. It prohibits users to create
table with non-unique primary key. The default value for the flag is set
to true in this patch. The verification happens on the RPC level. If the
server has the feature turned off, or the server is older compared to
the client - doesn't have the auto-incrementing feature -, the request
gets rejected in both cases.
Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Reviewed-on: http://gerrit.cloudera.org:8080/19523
Tested-by: Kudu Jenkins
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 7fafdd2803a2c747faa6789a1921d51186edfb6e)
Reviewed-on: http://gerrit.cloudera.org:8080/19676
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
8 files changed, 64 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19676
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) KUDU-1945 Auto-incrementing column feature flag
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19676 )
Change subject: KUDU-1945 Auto-incrementing column feature flag
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c3dde3705c25c36d3ad787c0db6ed03f6c2cfd
Gerrit-Change-Number: 19676
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 01 Apr 2023 07:10:08 +0000
Gerrit-HasComments: No