You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rednaxelafx (via GitHub)" <gi...@apache.org> on 2023/08/21 17:39:14 UTC
[GitHub] [spark] rednaxelafx commented on pull request #42550: [SPARK-44861][CONNECT] jsonignore SparkListenerConnectOperationStarted.planRequest
rednaxelafx commented on PR #42550:
URL: https://github.com/apache/spark/pull/42550#issuecomment-1686757658
Interesting. For the newly added events for Spark Connect Server, we don't have a test suite of golden files for the expected event logs, so this PR's change didn't affect any golden file updates. It'd be be great if we can have test parity with the other events and have golden file based testing added. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org