You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/04/17 06:34:09 UTC

[GitHub] [gobblin] treff7es commented on a change in pull request #3264: [GOBBLIN-1429] Add secure TrustManager for LDAP Utils

treff7es commented on a change in pull request #3264:
URL: https://github.com/apache/gobblin/pull/3264#discussion_r615215815



##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/LdapUtils.java
##########
@@ -87,7 +94,11 @@ private DirContext getDirContext(String username, String password) throws Naming
     env.put(Context.SECURITY_PRINCIPAL, username);
     env.put(Context.SECURITY_CREDENTIALS, password);
 
-    env.put("java.naming.ldap.factory.socket", TrustManagerSocketFactory.class.getCanonicalName());
+    if (_ldapUseSecureTrustManager) {
+      env.put("java.naming.ldap.factory.socket", TrustManagerSocketFactory.class.getCanonicalName());

Review comment:
       I think you mixed up the branches here as this one should be the secure one and the other one the non-secure one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org