You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hannah Nguyen (Code Review)" <ge...@cloudera.org> on 2019/06/26 00:35:47 UTC

[kudu-CR] Modify table scan tool to collect and surface errors instead of crashing

Hello Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13733

to look at the new patch set (#2).

Change subject: Modify table scan tool to collect and surface errors instead of crashing
......................................................................

Modify table scan tool to collect and surface errors instead of crashing

Initialized a Status for each thread in StartWork().
Replaced CHECKs in ScanData() with return of bad Status.
ScanTask() or CopyTask() catch bad Statuses from ScanData() in 
out-parameter back to StartWork().
StartWork() logs and returns the first bad Status from the thread pool.

Change-Id: Ic45da537b8bacfa9625010536ea82da9a6e76100
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
3 files changed, 61 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/13733/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic45da537b8bacfa9625010536ea82da9a6e76100
Gerrit-Change-Number: 13733
Gerrit-PatchSet: 2
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)