[jira] [Commented] (ARTEMIS-2094) Configuration change loss after failover to slave

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628674#comment-16628674 ] 

ASF GitHub Bot commented on ARTEMIS-2094:
-----------------------------------------

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2326
  
    @jbertram , @clebertsuconic can this be merged? And also cherry picked to 2.6.x this is causing issues. 


> Configuration change loss after failover to slave
> -------------------------------------------------
>
>                 Key: ARTEMIS-2094
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2094
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.6.3
>            Reporter: Michael Andre Pearce
>            Assignee: Michael Andre Pearce
>            Priority: Major
>
> This is further cases discovered during testing network failures.
> Essentially we have noticed when config settings are reloaded such as address-setting or security-setting, the live node correctly reloads, but after live failure the backup activates, the backup does not contain these changes due to the configuration object held inside ActiveMQServerImpl is out of date to when the backup server first started.
> so further enhancements/bug fixes on top of ARTEMIS-1747 - Fix Configuration change loss when network Issue. which fixed this for an active node. Essentially we just need to keep the updating of the configuration object in ActiveMQServerImpl outside the isActive check.
> Also address-settings and security settings should be swap'd during initialisation phase 2, so these are set to latest config after activation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)