You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by wmarshall484 <gi...@git.apache.org> on 2016/06/21 23:20:34 UTC
[GitHub] incubator-quarks pull request #146: Fixed time-based batch windowing issue
GitHub user wmarshall484 opened a pull request:
https://github.com/apache/incubator-quarks/pull/146
Fixed time-based batch windowing issue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wmarshall484/incubator-quarks master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit e076676fc0c6aade99f123d6ad2f1b2e175239af
Author: wcmarsha <wc...@us.ibm.com>
Date: 2016-06-21T23:17:36Z
Fixed time-based batch windowing issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #146: Fixed time-based batch windowing issue
Posted by wmarshall484 <gi...@git.apache.org>.
Github user wmarshall484 commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/146#discussion_r67977253
--- Diff: api/window/src/main/java/quarks/window/Policies.java ---
@@ -69,11 +71,11 @@ Licensed to the Apache Software Foundation (ASF) under one
// Can't use lambda since state is required
return new BiConsumer<Partition<T,K,L>, T>() {
- private boolean first = true;
+ private Set<Partition<T,K,L>> initialized_partitions = new HashSet<>();
--- End diff --
Fixed in latest commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #146: Fixed time-based batch windowing issue
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/146#discussion_r67973272
--- Diff: api/window/src/main/java/quarks/window/Policies.java ---
@@ -69,11 +71,11 @@ Licensed to the Apache Software Foundation (ASF) under one
// Can't use lambda since state is required
return new BiConsumer<Partition<T,K,L>, T>() {
- private boolean first = true;
+ private Set<Partition<T,K,L>> initialized_partitions = new HashSet<>();
--- End diff --
needs to be a synchronized set
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #146: Fixed time-based batch windowing issue
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks/pull/146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---