You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2023/02/26 14:46:21 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3670: [SCB-2783]remove load balance handler and use filter
liubao68 opened a new pull request, #3670:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3670
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3670: [SCB-2783]remove load balance handler and use filter
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #3670:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3670: [SCB-2783]remove load balance handler and use filter
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3670:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3670#issuecomment-1445571392
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3670](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c693fb) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/3d2fcce6db47741cefad0ef9def8e7d93d5df0fc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d2fcce) will **increase** coverage by `0.37%`.
> The diff coverage is `46.51%`.
> :exclamation: Current head 1c693fb differs from pull request most recent head a1e27c0. Consider uploading reports for the commit a1e27c0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3670 +/- ##
============================================
+ Coverage 42.99% 43.37% +0.37%
- Complexity 5932 6013 +81
============================================
Files 1540 1542 +2
Lines 38540 38542 +2
Branches 3539 3538 -1
============================================
+ Hits 16569 16716 +147
+ Misses 20686 20521 -165
- Partials 1285 1305 +20
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...comb/core/filter/impl/SimpleLoadBalanceFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvaW1wbC9TaW1wbGVMb2FkQmFsYW5jZUZpbHRlci5qYXZh) | `0.00% <ø> (-79.42%)` | :arrow_down: |
| [...ervicecomb/edge/core/CommonHttpEdgeDispatcher.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWRnZS9lZGdlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2VkZ2UvY29yZS9Db21tb25IdHRwRWRnZURpc3BhdGNoZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/servicecomb/loadbalance/LoadBalanceFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvTG9hZEJhbGFuY2VGaWx0ZXIuamF2YQ==) | `76.06% <66.66%> (ø)` | |
| [...rvicecomb/core/filter/CoreFilterConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvQ29yZUZpbHRlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...comb/demo/springmvc/client/TestDateTimeSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXNwcmluZ212Yy9zcHJpbmdtdmMtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9kZW1vL3NwcmluZ212Yy9jbGllbnQvVGVzdERhdGVUaW1lU2NoZW1hLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [.../servicecomb/demo/zeroconfig/tests/ServerTest.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXplcm9jb25maWctc2NoZW1hZGlzY292ZXJ5LXJlZ2lzdHJ5L2RlbW8temVyb2NvbmZpZy1zY2hlbWFkaXNjb3ZlcnktcmVnaXN0cnktdGVzdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vemVyb2NvbmZpZy90ZXN0cy9TZXJ2ZXJUZXN0LmphdmE=) | `96.96% <100.00%> (+0.09%)` | :arrow_up: |
| [...vicecomb/loadbalance/LoadBalanceConfiguration.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvTG9hZEJhbGFuY2VDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...g/apache/servicecomb/loadbalance/LoadBalancer.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvTG9hZEJhbGFuY2VyLmphdmE=) | `64.28% <100.00%> (+64.28%)` | :arrow_up: |
| [...re/registry/discovery/EndpointDiscoveryFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9yZWdpc3RyeS9kaXNjb3ZlcnkvRW5kcG9pbnREaXNjb3ZlcnlGaWx0ZXIuamF2YQ==) | `50.00% <0.00%> (-20.00%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3670?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org