You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2025/11/19 08:13:15 UTC
[PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
yaooqinn opened a new pull request, #53127:
URL: https://github.com/apache/spark/pull/53127
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Upgrade Bootstrap v4.4.1 to v4.6.2
### Why are the changes needed?
UI dependency optimization
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
built and ran Spark SQL locally and viewed each page's presentation.
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #53127:
URL: https://github.com/apache/spark/pull/53127#discussion_r2541067984
##########
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##########
@@ -461,17 +461,19 @@ private[spark] object UIUtils extends Logging {
if (skipped > 0) s" ($skipped skipped)" else ""
} + killTaskReasonText
+ // scalastyle:off line.size.limit
<div class="progress">
- <span style="text-align:center; position:absolute; width:100%;" title={progressTitle}>
- {completed}/{total}
- { if (failed == 0 && skipped == 0 && started > 0) s"($started running)" }
- { if (failed > 0) s"($failed failed)" }
- { if (skipped > 0) s"($skipped skipped)" }
- { killTaskReasonText }
+ <span style="text-align:center; position:absolute; width:100%; height:100%; align-content: center" title={progressTitle}>
Review Comment:
Changes here make sure the progress bar stays aligned
<img width="636" height="260" alt="Image" src="https://github.com/user-attachments/assets/1bf50a28-f9db-4b8e-adf6-8cfc6fd17de8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #53127:
URL: https://github.com/apache/spark/pull/53127#issuecomment-3556011528
Thank you all, @peter-toth, @dongjoon-hyun, and @LuciferYang.
`UISeleniumSuite` has been recovered, merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #53127:
URL: https://github.com/apache/spark/pull/53127#issuecomment-3555988006
> Oh, `UISeleniumSuite` is covered by CI or the failure is a manual test result, @LuciferYang ?
covered by CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53127:
URL: https://github.com/apache/spark/pull/53127#issuecomment-3555983875
Oh, `UISeleniumSuite` is covered by CI or the failure is a manual test result, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #53127:
URL: https://github.com/apache/spark/pull/53127#discussion_r2541069582
##########
core/src/main/resources/org/apache/spark/ui/static/webui.css:
##########
@@ -30,13 +30,14 @@ h4 {
}
a,
-a:not([href]) {
+a:not([href]):not([class]) {
color: #0088cc;
text-decoration: none;
}
Review Comment:
The CSS selector change adds `:not([class])` to anchor tags without href attributes. This means styled anchor elements with classes (like Bootstrap's button classes) will no longer receive these base styles. Verify that this doesn't inadvertently break existing UI components that rely on these base anchor styles, particularly Bootstrap components that may have been added or changed in v4.6.2.
##########
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##########
@@ -461,17 +461,19 @@ private[spark] object UIUtils extends Logging {
if (skipped > 0) s" ($skipped skipped)" else ""
} + killTaskReasonText
+ // scalastyle:off line.size.limit
<div class="progress">
- <span style="text-align:center; position:absolute; width:100%;" title={progressTitle}>
- {completed}/{total}
- { if (failed == 0 && skipped == 0 && started > 0) s"($started running)" }
- { if (failed > 0) s"($failed failed)" }
- { if (skipped > 0) s"($skipped skipped)" }
- { killTaskReasonText }
+ <span style="text-align:center; position:absolute; width:100%; height:100%; align-content: center" title={progressTitle}>
Review Comment:
The inline style uses `align-content: center` which may not be supported in all browsers for this use case. Consider using `display: flex; align-items: center; justify-content: center` for more reliable cross-browser vertical centering, or ensure the target Bootstrap v4.6.2 properly supports this property for the intended layout.
```suggestion
<span style="display: flex; align-items: center; justify-content: center; position:absolute; width:100%; height:100%; text-align:center;" title={progressTitle}>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #53127:
URL: https://github.com/apache/spark/pull/53127#issuecomment-3552699976
```
[info] UISeleniumSuite:
[info] - all jobs page should be rendered even though we configure the scheduling mode to fair (3 seconds, 95 milliseconds)
[info] - effects of unpersist() / persist() should be reflected (3 seconds, 756 milliseconds)
[info] - failed stages should not appear to be active (2 seconds, 858 milliseconds)
[info] - spark.ui.killEnabled should properly control kill button display (8 seconds, 796 milliseconds)
[info] - jobs page should not display job group name unless some job was submitted in a job group (2 seconds, 642 milliseconds)
[info] - job progress bars should handle stage / task failures (2 seconds, 739 milliseconds)
[info] - job details page should display useful information for stages that haven't started (2 seconds, 258 milliseconds)
[info] - job progress bars / cells reflect skipped stages / tasks *** FAILED *** (12 seconds, 307 milliseconds)
[info] The code passed to eventually never returned normally. Attempted 53 times over 10.143391073999998 seconds. Last failure message: "8/8[](16 skipped)" was not equal to "8/8[ ](16 skipped)". (UISeleniumSuite.scala:436)
[info] org.scalatest.exceptions.TestFailedDueToTimeoutException:
[info] at org.scalatest.enablers.Retrying$$anon$4.tryTryAgain$2(Retrying.scala:219)
[info] at org.scalatest.enablers.Retrying$$anon$4.retry(Retrying.scala:226)
[info] at org.scalatest.concurrent.Eventually.eventually(Eventually.scala:313)
[info] at org.scalatest.concurrent.Eventually.eventually$(Eventually.scala:312)
[info] at org.scalatest.concurrent.Eventually$.eventually(Eventually.scala:457)
[info] at org.apache.spark.ui.UISeleniumSuite.$anonfun$new$69(UISeleniumSuite.scala:436)
[info] at org.apache.spark.LocalSparkContext$.withSpark(LocalSparkContext.scala:65)
[info] at org.apache.spark.ui.UISeleniumSuite.$anonfun$new$68(UISeleniumSuite.scala:427)
[info] at org.scalatest.enablers.Timed$$anon$1.timeoutAfter(Timed.scala:127)
[info] at org.scalatest.concurrent.TimeLimits$.failAfterImpl(TimeLimits.scala:282)
[info] at org.scalatest.concurrent.TimeLimits.failAfter(TimeLimits.scala:231)
[info] at org.scalatest.concurrent.TimeLimits.failAfter$(TimeLimits.scala:230)
[info] at org.apache.spark.SparkFunSuite.failAfter(SparkFunSuite.scala:68)
[info] at org.apache.spark.SparkFunSuite.$anonfun$test$2(SparkFunSuite.scala:154)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:20)
[info] at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:226)
```
A UI-related test has failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2 [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #53127: [SPARK-54413][UI] Upgrade Bootstrap v4.4.1 to v4.6.2
URL: https://github.com/apache/spark/pull/53127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org