You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by andrewmlim <gi...@git.apache.org> on 2018/10/16 16:09:02 UTC
[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...
GitHub user andrewmlim opened a pull request:
https://github.com/apache/nifi/pull/3080
NIFI-5701 Add documentation for Load Balancing connections to User Gu…
…ide and add additional properties to Admin Guide
Also updated some existing screenshots and did some reformatting of some titles.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewmlim/nifi NIFI-5701
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3080
----
commit 652146287bd7c6ea8fc73fef8755d3b91fa87413
Author: Andrew Lim <an...@...>
Date: 2018-10-16T16:06:31Z
NIFI-5701 Add documentation for Load Balancing connections to User Guide and add additional properties to Admin Guide
----
---
[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3080#discussion_r225673660
--- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc ---
@@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those Connections.
==== Settings
-The Settings Tab provides the ability to configure the Connection's name, FlowFile expiration, Back Pressure thresholds, and
-Prioritization:
+The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:
--- End diff --
```suggestion
The Settings tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:
```
---
[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3080#discussion_r225654613
--- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc ---
@@ -636,21 +637,24 @@ For example:
For additional information and examples, see the link:http://www.quartz-scheduler.org/documentation/quartz-2.x/tutorials/crontrigger.html[Chron Trigger Tutorial^] in the Quartz documentation.
+===== Concurrent Tasks
Next, the Scheduling Tab provides a configuration option named 'Concurrent Tasks'. This controls how many threads the Processor
will use. Said a different way, this controls how many FlowFiles should be processed by this Processor at the same time. Increasing
this value will typically allow the Processor to handle more data in the same amount of time. However, it does this by using system
resources that then are not usable by other Processors. This essentially provides a relative weighting of Processors -- it controls
how much of the system's resources should be allocated to this Processor instead of other Processors. This field is available for
most Processors. There are, however, some types of Processors that can only be scheduled with a single Concurrent task.
+===== Run Schedule
The 'Run Schedule' dictates how often the Processor should be scheduled to run. The valid values for this field depend on the selected
Scheduling Strategy (see above). If using the Event driven Scheduling Strategy, this field is not available. When using the Timer driven
Scheduling Strategy, this value is a time duration specified by a number followed by a time unit. For example, `1 second` or `5 mins`.
The default value of `0 sec` means that the Processor should run as often as possible as long as it has data to process. This is true
for any time duration of 0, regardless of the time unit (i.e., `0 sec`, `0 mins`, `0 days`). For an explanation of values that are
applicable for the CRON driven Scheduling Strategy, see the description of the CRON driven Scheduling Strategy itself.
-When configured for clustering, an Execution setting will be available. This setting is used to determine which node(s) the Processor will be
+===== Execution
+The Execution setting is used to determine which node(s) the Processor will be
--- End diff --
```suggestion
The Execution setting is used to determine on which node(s) the Processor will be
```
---
[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3080#discussion_r225686661
--- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc ---
@@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those Connections.
==== Settings
-The Settings Tab provides the ability to configure the Connection's name, FlowFile expiration, Back Pressure thresholds, and
-Prioritization:
+The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:
--- End diff --
I would prefer tab being lowercased, since it's not part of the title of the actual tab.
---
[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3080
---
[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...
Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3080#discussion_r225687626
--- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc ---
@@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those Connections.
==== Settings
-The Settings Tab provides the ability to configure the Connection's name, FlowFile expiration, Back Pressure thresholds, and
-Prioritization:
+The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:
--- End diff --
Sounds good
---
[GitHub] nifi pull request #3080: NIFI-5701 Add documentation for Load Balancing conn...
Posted by andrewmlim <gi...@git.apache.org>.
Github user andrewmlim commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3080#discussion_r225685340
--- Diff: nifi-docs/src/main/asciidoc/user-guide.adoc ---
@@ -986,13 +991,11 @@ automatically be 'cloned', and a copy will be sent to each of those Connections.
==== Settings
-The Settings Tab provides the ability to configure the Connection's name, FlowFile expiration, Back Pressure thresholds, and
-Prioritization:
+The Settings Tab provides the ability to configure the Connection's Name, FlowFile Expiration, Back Pressure Thresholds, Load Balance Strategy and Prioritization:
--- End diff --
There are other instances in the doc where tab is capitalized similarly:
-Line 641 "Scheduling Tab"
-Line 680 "Properties Tab"
-Line 681 "Properties Tab"
-Line 981 "Details Tab"
But other instances where it is not capitalized:
-Lines 716 & 717 "Comments tab"
I'm OK with either style, but we should be consistent. So if you like the non-capitalized versions, we need to edit the 4 other instances I noted above.
---