You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by me...@apache.org on 2023/06/26 10:27:21 UTC

[myfaces] branch main updated: Using installed chromedriver on github runner (#591)

This is an automated email from the ASF dual-hosted git repository.

melloware pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/myfaces.git


The following commit(s) were added to refs/heads/main by this push:
     new ebf0ba897 Using installed chromedriver on github runner (#591)
ebf0ba897 is described below

commit ebf0ba897f8169a14592dc6d0b97f3f7d8e11eb3
Author: Bernd Bohmann <bo...@apache.org>
AuthorDate: Mon Jun 26 12:27:15 2023 +0200

    Using installed chromedriver on github runner (#591)
---
 .github/workflows/myfaces-ci.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/myfaces-ci.yml b/.github/workflows/myfaces-ci.yml
index ab8185206..bb942985c 100644
--- a/.github/workflows/myfaces-ci.yml
+++ b/.github/workflows/myfaces-ci.yml
@@ -69,8 +69,9 @@ jobs:
           key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
           restore-keys: ${{ runner.os }}-m2
       - name: Build with Maven
+        # CHROMEWEBDRIVER env variable https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#environment-variables-1
         run: |
-          if ! mvn -B -V clean verify checkstyle:check apache-rat:check -Dformats=XML -DchromeDriverVersion=112.0.5615.49 -f pom.xml; then
+          if ! mvn -B -V clean verify checkstyle:check apache-rat:check -Dformats=XML "-Dwebdriver.chrome.driver=$CHROMEWEBDRIVER/chromedriver" -f pom.xml; then
             find . \( -path '*/target/surefire-reports/*.xml' -o -path '*/target/failsafe-reports/*.xml' -o -path '*/target/rat.txt' -o -path '*/target/checkstyle-result.xml' -o -path '*/target/dependency-check-report.xml' \) | zip -q reports.zip -@
             exit 1
           fi